Skip to content

neofs cli container list lists nothing #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2025
Merged

neofs cli container list lists nothing #3613

merged 2 commits into from
Oct 3, 2025

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Oct 3, 2025

Closes #3307.

@End-rey End-rey self-assigned this Oct 3, 2025
@End-rey End-rey force-pushed the 3307-neofs-cli-container-list-lists-nothing branch from 7d5a63f to e206d88 Compare October 3, 2025 11:03
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.66%. Comparing base (2a76d31) to head (2a1293e).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-cli/modules/container/list.go 0.00% 6 Missing ⚠️
pkg/services/container/server.go 0.00% 4 Missing ⚠️
cmd/neofs-node/container.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
+ Coverage   26.58%   26.66%   +0.07%     
==========================================
  Files         653      653              
  Lines       50006    50023      +17     
==========================================
+ Hits        13296    13337      +41     
+ Misses      35661    35646      -15     
+ Partials     1049     1040       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@End-rey End-rey force-pushed the 3307-neofs-cli-container-list-lists-nothing branch from e206d88 to cd03324 Compare October 3, 2025 12:27
roman-khimov
roman-khimov reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK otherwise + add an issue for testcases to cover this

@End-rey End-rey force-pushed the 3307-neofs-cli-container-list-lists-nothing branch from cd03324 to 2a1293e Compare October 3, 2025 13:24
@End-rey
cli/cnr: fix container list lists nothing
2a1293e 
Now, if omit the flags with owner and wallet, it is possible to obtain a list of
all containers.

Closes #3307.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey mentioned this pull request Oct 3, 2025
Open
@roman-khimov roman-khimov merged commit 3fadbae into master Oct 3, 2025
18 of 19 checks passed
@roman-khimov roman-khimov deleted the 3307-neofs-cli-container-list-lists-nothing branch October 3, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

@End-rey End-rey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

neofs-cli container list lists nothing

2 participants

@End-rey @roman-khimov