neofs cli container list lists nothing (#3613)

Closes #3307.

Author: roman-khimov

CHANGELOG.md

@@ -18,6 +18,7 @@ Changelog for NeoFS Node
 - Empty storage and error-free startup when changing layout parameters (#3594)
 - Flaky storage evacuation unit test (#3605)
 - Incorrect search request from SN when processing tombstones (#3610)
+- `neofs-cli container list` lists nothing if there are no flags (#3613)
 
 ### Changed
 - Stream payload without buffering to reduce memory usage in CLI `Get/Put` operations (#3535)

cmd/neofs-cli/internal/key/raw.go

@@ -27,15 +27,15 @@ func Get(cmd *cobra.Command) (*ecdsa.PrivateKey, error) {
 	return pk, nil
 }
 
-var errMissingFlag = errors.New("missing key flag")
+var ErrMissingFlag = errors.New("missing key flag")
 
 // get decodes ecdsa.PrivateKey from the wallet file located in the path
 // stored by commonflags.WalletPath viper key. Returns errMissingFlag
 // if the viper flag is not set.
 func get(cmd *cobra.Command) (*ecdsa.PrivateKey, error) {
 	keyDesc := viper.GetString(commonflags.WalletPath)
 	if keyDesc == "" {
-		return nil, errMissingFlag
+		return nil, ErrMissingFlag
 	}
 	w, err := wallet.NewWalletFromFile(keyDesc)
 	if err != nil {
@@ -60,7 +60,7 @@ func GetOrGenerate(cmd *cobra.Command) (*ecdsa.PrivateKey, error) {
 func getOrGenerate(cmd *cobra.Command) (*ecdsa.PrivateKey, error) {
 	if !viper.GetBool(commonflags.GenerateKey) {
 		key, err := get(cmd)
-		if !errors.Is(err, errMissingFlag) {
+		if !errors.Is(err, ErrMissingFlag) {
 			if err == nil {
 				common.PrintVerbose(cmd, "Configured wallet will be used for the command.")
 			}

cmd/neofs-cli/modules/container/list.go

@@ -1,6 +1,7 @@
 package container
 
 import (
+	"errors"
 	"fmt"
 
 	internalclient "github.com/nspcc-dev/neofs-node/cmd/neofs-cli/internal/client"
@@ -31,18 +32,18 @@ var listContainersCmd = &cobra.Command{
 	RunE: func(cmd *cobra.Command, _ []string) error {
 		var idUser user.ID
 
-		key, err := key.GetOrGenerate(cmd)
-		if err != nil {
+		pk, err := key.Get(cmd)
+		if err != nil && !errors.Is(err, key.ErrMissingFlag) {
 			return err
 		}
 
-		if flagVarListContainerOwner == "" {
-			idUser = user.NewFromECDSAPublicKey(key.PublicKey)
-		} else {
+		if flagVarListContainerOwner != "" {
 			err := idUser.DecodeString(flagVarListContainerOwner)
 			if err != nil {
 				return fmt.Errorf("invalid user ID: %w", err)
 			}
+		} else if pk != nil {
+			idUser = user.NewFromECDSAPublicKey(pk.PublicKey)
 		}
 
 		ctx, cancel := commonflags.GetCommandContext(cmd)
@@ -83,7 +84,7 @@ func initContainerListContainersCmd() {
 	flags := listContainersCmd.Flags()
 
 	flags.StringVar(&flagVarListContainerOwner, flagListContainerOwner, "",
-		"Owner of containers (omit to use owner from private key)",
+		"Owner of containers (omit to use owner from private key or if no key provided - list all containers)",
 	)
 	flags.BoolVar(&flagVarListPrintAttr, flagListPrintAttr, false,
 		"Request and print attributes of each container",

cmd/neofs-node/container.go

@@ -371,6 +371,9 @@ func (x *containersInChain) GetEACL(id cid.ID) (eacl.Table, error) {
 }
 
 func (x *containersInChain) List(id user.ID) ([]cid.ID, error) {
+	if id.IsZero() {
+		return x.cnrLst.List(nil)
+	}
 	return x.cnrLst.List(&id)
 }
 

docs/cli-commands/neofs-cli_container_list.md

@@ -16,7 +16,7 @@ neofs-cli container list [flags]
       --address string        Address of wallet account
   -g, --generate-key          Generate new private key
   -h, --help                  help for list
-      --owner string          Owner of containers (omit to use owner from private key)
+      --owner string          Owner of containers (omit to use owner from private key or if no key provided - list all containers)
   -r, --rpc-endpoint string   Remote node address (as 'multiaddr' or '<host>:<port>')
   -t, --timeout duration      Timeout for the operation (default 15s)
       --ttl uint32            TTL value in request meta header (default 2)

pkg/services/container/server.go

@@ -14,6 +14,7 @@ import (
 	"github.com/nspcc-dev/neo-go/pkg/neorpc/result"
 	"github.com/nspcc-dev/neo-go/pkg/smartcontract/trigger"
 	icrypto "github.com/nspcc-dev/neofs-node/internal/crypto"
+	islices "github.com/nspcc-dev/neofs-node/internal/slices"
 	"github.com/nspcc-dev/neofs-node/pkg/core/netmap"
 	"github.com/nspcc-dev/neofs-node/pkg/services/util"
 	apistatus "github.com/nspcc-dev/neofs-sdk-go/client/status"
@@ -430,8 +431,10 @@ func (s *server) List(_ context.Context, req *protocontainer.ListRequest) (*prot
 	}
 
 	var id user.ID
-	if err := id.FromProtoMessage(mID); err != nil {
-		return s.makeFailedListResponse(fmt.Errorf("invalid user: %w", err))
+	if len(mID.Value) != user.IDSize || !islices.AllZeros(mID.Value) {
+		if err := id.FromProtoMessage(mID); err != nil {
+			return s.makeFailedListResponse(fmt.Errorf("invalid user: %w", err))
+		}
 	}
 
 	cs, err := s.contract.List(id)