Skip to content

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Dec 18, 2024

Important

Refactor src/interaction.ts to use specific d3 types, add TypeScript error comments, and log renderer attachment.

  • Imports:
    • Refactor imports in src/interaction.ts to use more specific types from d3-selection, d3-timer, and d3-zoom.
    • Replace d3.Selection with Selection, d3.ContainerElement with ContainerElement, d3.Timer with Timer, d3.ZoomBehavior with ZoomBehavior, and d3.ZoomTransform with ZoomTransform.
  • Code Comments:
    • Add @ts-expect-error comments in zoom_to() and zoom_to_bbox() methods to handle TypeScript errors.
  • Logging:
    • Add console log statement in attach_renderer() method to log when a renderer is attached.

This description was created by Ellipsis for 3e1b193. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented Dec 18, 2024

}

attach_renderer(key: string, renderer: Renderer) {
console.log("ATTACHING RENDERER")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log statement appears to be a debugging artifact and should be removed before merging to production.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@bmschmidt bmschmidt marked this pull request as ready for review January 16, 2025 19:51
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage branch from 18fd8c0 to 98af6ed Compare May 23, 2025 18:29
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 3e1b193 to 0833ce7 Compare May 23, 2025 18:29
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage branch from 98af6ed to 19505f0 Compare May 23, 2025 18:37
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 0833ce7 to 89a8717 Compare May 23, 2025 18:37
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage branch from 19505f0 to 9475c8a Compare May 23, 2025 18:40
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 89a8717 to 0ae3757 Compare May 23, 2025 18:40
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage branch from 9475c8a to 2365605 Compare May 23, 2025 18:46
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 0ae3757 to 61aaf34 Compare May 23, 2025 18:46
@bmschmidt bmschmidt marked this pull request as draft May 23, 2025 18:48
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage branch from 2365605 to 4c76c23 Compare May 23, 2025 19:12
@bmschmidt bmschmidt force-pushed the 12-17-refactor_buffer_storage_split branch from 61aaf34 to f5d0d3a Compare May 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant