-
Notifications
You must be signed in to change notification settings - Fork 69
uv for quadfeather #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
uv for quadfeather #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
60d27f4 to
357ca6e
Compare
181fa0a to
0dd3c20
Compare
5077ab8 to
de57740
Compare
This was referenced Nov 11, 2024
This was referenced Dec 16, 2024
Draft
Draft
89b9a63 to
5703fd8
Compare
de57740 to
12fb692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 12fb692 in 1 minute and 53 seconds. Click for details.
- Reviewed
203lines of code in4files - Skipped
1files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .python-version:1
- Draft comment:
Python version is set to 3.12. Verify that this upgrade (from earlier 3.9/3.10 mentions) is intentional for compatibility. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold70%This comment is asking the PR author to verify the intention behind upgrading the Python version, which violates the rule against asking for confirmation of intention. It does not provide a specific suggestion or point out a specific issue with the code.
2. README.md:57
- Draft comment:
The tone in the package management instructions is informal. Consider using a more professional phrasing. - Reason this comment was not posted:
Confidence changes required:50%<= threshold70%None
3. pyproject.toml:4
- Draft comment:
The project description is still a placeholder. Update it to reflect Deep Scatterplots’ purpose. - Reason this comment was not posted:
Confidence changes required:70%<= threshold70%None
4. pyproject.toml:6
- Draft comment:
The Python requirement is set to '>=3.12'. Confirm this is intentional as it may exclude users on slightly older versions. - Reason this comment was not posted:
Confidence changes required:70%<= threshold70%None
5. uv.lock:1
- Draft comment:
This auto-generated lock file pins dependencies (including the quadfeather git commit). Ensure it remains updated and consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold70%None
6. README.md:57
- Draft comment:
Typographical suggestion: 'python' should be capitalized as 'Python' when referring to the programming language. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 70% While technically correct that 'Python' should be capitalized when referring to the programming language, this is a very minor typographical issue in documentation. The rules state not to make comments that are obvious or unimportant. This seems like a very low-priority change that doesn't affect functionality or code quality. The capitalization of Python is the official style guide recommendation, so there's an argument for consistency and professionalism in documentation. While correct, this type of minor documentation fix doesn't warrant a PR comment - it's too trivial and could be fixed in a general documentation pass if needed. Delete this comment as it violates the rule about not making obvious or unimportant comments. This minor typographical suggestion doesn't merit a PR comment.
Workflow ID: wflow_jYD3IEYYNdTcsSLE
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
5703fd8 to
8f25b89
Compare
12fb692 to
b9d0d80
Compare
8f25b89 to
7a83241
Compare
b9d0d80 to
1aa0ac1
Compare
7a83241 to
ee5e075
Compare
1aa0ac1 to
d86e17a
Compare
d86e17a to
12638bd
Compare
RLesser
approved these changes
May 23, 2025
This was referenced May 26, 2025
Merge activity
|
12638bd to
fcacb0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Important
This PR updates the project to use Python 3.12 and
uvfor package management, addingpyproject.tomlanduv.lockfor dependency management..python-versionfile specifying Python 3.12.README.mdto useuvfor managing Python packages instead ofpip.pyproject.tomlto define project metadata and dependencies, includingquadfeather.uv.lockto lock dependencies, includingnumpy,pandas,pyarrow, andquadfeather.This description was created by
for 12fb692. You can customize this summary. It will automatically update as commits are pushed.