Skip to content

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Oct 1, 2024

Important

This PR updates the project to use Python 3.12 and uv for package management, adding pyproject.toml and uv.lock for dependency management.

  • Python Version:
    • Adds .python-version file specifying Python 3.12.
  • Package Management:
    • Updates README.md to use uv for managing Python packages instead of pip.
    • Adds pyproject.toml to define project metadata and dependencies, including quadfeather.
    • Introduces uv.lock to lock dependencies, including numpy, pandas, pyarrow, and quadfeather.

This description was created by Ellipsis for 12fb692. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented Oct 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bmschmidt bmschmidt mentioned this pull request Oct 1, 2024
@bmschmidt bmschmidt marked this pull request as ready for review October 1, 2024 01:03
@bmschmidt bmschmidt force-pushed the allow-subfield-access branch 4 times, most recently from 60d27f4 to 357ca6e Compare October 2, 2024 03:13
@bmschmidt bmschmidt force-pushed the allow-subfield-access branch 2 times, most recently from 181fa0a to 0dd3c20 Compare October 11, 2024 01:36
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from 5077ab8 to de57740 Compare November 11, 2024 17:02
@bmschmidt bmschmidt changed the base branch from allow-subfield-access to 11-03-cleaner_deeptable_instantiation_pattern November 11, 2024 17:02
@bmschmidt bmschmidt force-pushed the 11-03-cleaner_deeptable_instantiation_pattern branch 2 times, most recently from 89b9a63 to 5703fd8 Compare May 23, 2025 18:29
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from de57740 to 12fb692 Compare May 23, 2025 18:29
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 12fb692 in 1 minute and 53 seconds. Click for details.
  • Reviewed 203 lines of code in 4 files
  • Skipped 1 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .python-version:1
  • Draft comment:
    Python version is set to 3.12. Verify that this upgrade (from earlier 3.9/3.10 mentions) is intentional for compatibility.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 70% This comment is asking the PR author to verify the intention behind upgrading the Python version, which violates the rule against asking for confirmation of intention. It does not provide a specific suggestion or point out a specific issue with the code.
2. README.md:57
  • Draft comment:
    The tone in the package management instructions is informal. Consider using a more professional phrasing.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 70% None
3. pyproject.toml:4
  • Draft comment:
    The project description is still a placeholder. Update it to reflect Deep Scatterplots’ purpose.
  • Reason this comment was not posted:
    Confidence changes required: 70% <= threshold 70% None
4. pyproject.toml:6
  • Draft comment:
    The Python requirement is set to '>=3.12'. Confirm this is intentional as it may exclude users on slightly older versions.
  • Reason this comment was not posted:
    Confidence changes required: 70% <= threshold 70% None
5. uv.lock:1
  • Draft comment:
    This auto-generated lock file pins dependencies (including the quadfeather git commit). Ensure it remains updated and consistent.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 70% None
6. README.md:57
  • Draft comment:
    Typographical suggestion: 'python' should be capitalized as 'Python' when referring to the programming language.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 70% While technically correct that 'Python' should be capitalized when referring to the programming language, this is a very minor typographical issue in documentation. The rules state not to make comments that are obvious or unimportant. This seems like a very low-priority change that doesn't affect functionality or code quality. The capitalization of Python is the official style guide recommendation, so there's an argument for consistency and professionalism in documentation. While correct, this type of minor documentation fix doesn't warrant a PR comment - it's too trivial and could be fixed in a general documentation pass if needed. Delete this comment as it violates the rule about not making obvious or unimportant comments. This minor typographical suggestion doesn't merit a PR comment.

Workflow ID: wflow_jYD3IEYYNdTcsSLE

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@bmschmidt bmschmidt force-pushed the 11-03-cleaner_deeptable_instantiation_pattern branch from 5703fd8 to 8f25b89 Compare May 23, 2025 18:36
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from 12fb692 to b9d0d80 Compare May 23, 2025 18:36
@bmschmidt bmschmidt force-pushed the 11-03-cleaner_deeptable_instantiation_pattern branch from 8f25b89 to 7a83241 Compare May 23, 2025 18:39
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from b9d0d80 to 1aa0ac1 Compare May 23, 2025 18:39
@bmschmidt bmschmidt force-pushed the 11-03-cleaner_deeptable_instantiation_pattern branch from 7a83241 to ee5e075 Compare May 23, 2025 18:45
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from 1aa0ac1 to d86e17a Compare May 23, 2025 18:45
@bmschmidt bmschmidt requested a review from rguo123 May 23, 2025 18:47
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from d86e17a to 12638bd Compare May 23, 2025 19:11
@bmschmidt bmschmidt requested a review from RLesser May 23, 2025 21:22
Copy link
Collaborator Author

bmschmidt commented May 26, 2025

Merge activity

  • May 26, 4:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 4:25 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 26, 4:27 PM UTC: @bmschmidt merged this pull request with Graphite.

@bmschmidt bmschmidt changed the base branch from 11-03-cleaner_deeptable_instantiation_pattern to graphite-base/154 May 26, 2025 16:22
@bmschmidt bmschmidt changed the base branch from graphite-base/154 to main May 26, 2025 16:24
@bmschmidt bmschmidt force-pushed the 09-30-uv_for_quadfeather branch from 12638bd to fcacb0e Compare May 26, 2025 16:25
@bmschmidt bmschmidt merged commit c0c68ae into main May 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants