Skip to content

fix: double-update is now a nop in avail #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: double-update is now a nop in avail #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1953dc
fix: double-update is now a nop in avail
prestwich Mar 7, 2023
f4b7ff3
chore: changelog
prestwich Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions chains/nomad-substrate/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

### Unreleased

- Change `double_update` to a NOP
- Update `update` method with new max index field
- `produce_update` checks that tree has at least 1 element (bug fix)
- Add timelag functionality to `NomadOnlineClient` which wraps storage fetches with timelagged fetches
Expand Down
4 changes: 3 additions & 1 deletion chains/nomad-substrate/src/home.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,9 @@ where

#[tracing::instrument(err, skip(self))]
async fn double_update(&self, _double: &DoubleUpdate) -> Result<TxOutcome, Self::Error> {
unimplemented!("Double update deprecated for Substrate implementations")
Ok(TxOutcome {
txid: Default::default(),
})
}
}

Expand Down