Skip to content

fix: double-update is now a nop in avail #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: double-update is now a nop in avail #251

wants to merge 2 commits into from

Conversation

prestwich
Copy link
Member

Motivation

Resolve panic issue in avail testing

Solution

Remove unimplemented! and replace with a nop outcome

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package
  • Ran PR in local/dev/staging

@prestwich prestwich added the fix label Mar 7, 2023
@prestwich prestwich requested review from lattejed and rswanson March 7, 2023 01:54
@prestwich prestwich self-assigned this Mar 7, 2023
rswanson
rswanson approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@rswanson rswanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦢

lattejed
lattejed approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@lattejed lattejed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswanson rswanson rswanson approved these changes

+1 more reviewer

@lattejed lattejed lattejed approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@prestwich prestwich

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestwich @lattejed @rswanson