Skip to content

FIX: Provide FD arguments to combined plot function in BOLD notebook #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FIX: Provide FD arguments to combined plot function in BOLD notebook #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/notebooks/bold_realignment.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
"\n",
"\n",
"def plot_combined_profile(\n",
" images, afni_fd, nifreeze_fd, indexing=None, figsize=(15, 1.7), cmap=\"gray\", labels=None\n",
" images, _afni_fd, _nifreeze_fd, indexing=None, figsize=(15, 1.7), cmap=\"gray\", labels=None\n",
"):\n",
" # Calculate the number of profile plots\n",
" n_images = len(images)\n",
Expand All @@ -258,7 +258,7 @@
" )\n",
"\n",
" # Plot the framewise displacement on the first axis\n",
" fd = pd.DataFrame({\"afni\": afni_fd, \"nifreeze\": nifreeze_fd})\n",
" fd = pd.DataFrame({\"afni\": _afni_fd, \"nifreeze\": _nifreeze_fd})\n",
" fd_axis = axes[0]\n",
" _ = plot_framewise_displacement(fd, [\"AFNI 3dVolreg FD\", \"nifreeze FD\"], ax=fd_axis)\n",
"\n",
Expand Down Expand Up @@ -298,6 +298,8 @@
"source": [
"plot_combined_profile(\n",
" (DATA_PATH / bold_runs[15], afni_realigned[15], afni_realigned[15]),\n",
" afni_fd,\n",
" nifreeze_fd,\n",
Comment on lines +301 to +302
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not ever calculated explicitly. It does look like some cell is gone.

" labels=(\"hmc1\", \"original\", \"hmc2\"),\n",
");"
]
Expand Down