Linting: Add linting of topics #3902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashehu
reviewed
Nov 14, 2025
| topic_val = re.split(r',(?=(?:[^\'"]*[\'"][^\'"]*[\'"])*[^\'"]*$)', topic_val)[ | ||
| 0 | ||
| ] # Takes only first part, avoid commas in quotes | ||
| topic_val = topic_val.strip().strip("'").strip('"') # remove quotes and whitespaces |
Contributor
There was a problem hiding this comment.
could not malforme the removal of quotes the eval statement?
Member
Author
There was a problem hiding this comment.
I copied this piece of code from the outputs section, I think it will break the statement in some cases, but I am not sure what is best. What's your opinion?
Contributor
There was a problem hiding this comment.
i would just strip() the whitespace.
mashehu
approved these changes
Nov 14, 2025
Contributor
mashehu
left a comment
mashehu
left a comment
There was a problem hiding this comment.
do we need more specific tests for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linting of the
topicssection in themeta.ymlfile and the funcitonality to fix them.