Skip to content

Conversation

nick-youngblut
Copy link

  • compression of temp fastq files
    • SPLIT_SEQ module
  • replaced nanofilt with chopper
    • CHOPPER module

I haven't updated some of the extras (e.g., CHANGELOG), since I'm not sure how you want to structure them (e.g., what release version?).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scnanoseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@nick-youngblut nick-youngblut mentioned this pull request May 13, 2025
@lianov
Copy link
Member

lianov commented May 28, 2025

@nick-youngblut : wanted to provide you a quick update here. We are doing some internal tests for the 1.2.0 release which will hopefully be out within the next couple of weeks pending our checks and the experience of some of our internal UAB users. We are leaving your PR for release 1.3.0 to minimize scope for 1.2.0. But as soon as we release 1.2.0 we will start looking at this PR. Again, thanks so much for the contribution, we think this is a great feature for scnanoseq. We will continue to keep you posted.

@nick-youngblut
Copy link
Author

@lianov thanks for the update!
I've been trying to contribute to various open source bioinformatics codebases lately, given how quickly one can now work with AI coding tools (e.g., Claude, Cursor, Codex, etc). I hope this PR at least provides some guidance (for your LLM coder) to reduce temporary storage space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants