Chaning directories for logs and state files

src/gui/accountmanager.cpp

@@ -132,6 +132,7 @@ AccountManager::AccountsRestoreResult AccountManager::restore(const bool alsoRes
             const auto jar = qobject_cast<CookieJar*>(acc->_networkAccessManager->cookieJar());
             Q_ASSERT(jar);
             if (jar) {
+                acc->tryMigrateCookieJar();
                 jar->restore(acc->cookieJarPath());
             }
             addAccountState(accState);

src/gui/syncrunfilelog.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QRegularExpression>
 
 #include "syncrunfilelog.h"
 #include "common/utility.h"
@@ -24,7 +24,7 @@
 {
     const qint64 logfileMaxSize = 10 * 1024 * 1024; // 10MiB
 
-    const QString logpath = QStandardPaths::writableLocation(QStandardPaths::AppDataLocation);
+    const QString logpath = QStandardPaths::writableLocation(QStandardPaths::StateLocation);
     if(!QDir(logpath).exists()) {
         QDir().mkdir(logpath);
     }

src/gui/updater/ocupdater.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "theme.h"
 #include "configfile.h"
 #include "common/utility.h"
 #include "accessmanager.h"
@@ -219,7 +219,7 @@
             return QDir::toNativeSeparators(path);
         };
 
-        QString msiLogFile = cfg.configPath() + "msi.log";
+        QString msiLogFile = cfg.logDir() + "msi.log";
         QString command = QStringLiteral("&{msiexec /i '%1' /L*V '%2'| Out-Null ; &'%3'}")
              .arg(preparePathForPowershell(updateFile))
              .arg(preparePathForPowershell(msiLogFile))

src/libsync/account.cpp

@@ -1,3 +1,3 @@
 /*
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2013 ownCloud GmbH
@@ -400,9 +400,25 @@
     jar->setParent(oldParent); // takes it back
 }
 
+void Account::tryMigrateCookieJar()
+{
+    QString oldCookieJarPath = QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation) + "/cookies" + id() + ".db";
+    if (QFile::exists(oldCookieJarPath))
+    {
+        if (QFile::exists(cookieJarPath()))
+        {
+            qWarning() << "Both old cookie jar and new cookie jar exists. Abort migration";
+            return;
+        }
+        qDebug() << "Migrating cookie jar from "<< oldCookieJarPath << "to " << cookieJarPath();
+        if (!QFile::rename(oldCookieJarPath, cookieJarPath()))
+            qWarning() << "Failed to migrate cookie jar";
+    }
+}
+
 QString Account::cookieJarPath()
 {
-    return QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation) + "/cookies" + id() + ".db";
+    return QStandardPaths::writableLocation(QStandardPaths::StateLocation) + "/cookies" + id() + ".db";
 }
 
 void Account::resetNetworkAccessManager()

src/libsync/account.h

@@ -301,6 +301,7 @@ class OWNCLOUDSYNC_EXPORT Account : public QObject
 
     void clearCookieJar();
     void lendCookieJarTo(QNetworkAccessManager *guest);
+    void tryMigrateCookieJar();
     QString cookieJarPath();
 
     void resetNetworkAccessManager();

src/libsync/configfile.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "config.h"
 
 #include "configfile.h"
 #include "theme.h"
@@ -1118,7 +1118,7 @@
 
 QString ConfigFile::logDir() const
 {
-    const auto defaultLogDir = QString(configPath() + QStringLiteral("/logs"));
+    const auto defaultLogDir = QString(QStandardPaths::writableLocation(QStandardPaths::StateLocation) + QStringLiteral("/logs"));
     QSettings settings(configFile(), QSettings::IniFormat);
     return settings.value(QLatin1String(logDirC), defaultLogDir).toString();
 }

test/CMakeLists.txt

@@ -98,6 +98,7 @@ nextcloud_add_test(FileTagModel)
 nextcloud_add_test(SyncConflictsModel)
 nextcloud_add_test(DateFieldBackend)
 nextcloud_add_test(ClientStatusReporting)
+nextcloud_add_test(CookieJarMigration)
 
 nextcloud_add_test(FileSystem)
 

test/testcookiejarmigration.cpp

@@ -0,0 +1,85 @@
+/*
+   This software is in the public domain, furnished "as is", without technical
+   support, and with no warranty, express or implied, as to its usefulness for
+   any purpose.
+*/
+
+#include <QtTest>
+
+#include "account.h"
+#include "accountmanager.h"
+#include "logger.h"
+
+using namespace OCC;
+
+class TestCookieJarMigration : public QObject
+{
+    Q_OBJECT
+    AccountPtr _account;
+    QString oldCookieJarPath;
+
+private slots:
+    void initTestCase()
+    {
+        OCC::Logger::instance()->setLogFlush(true);
+        OCC::Logger::instance()->setLogDebug(true);
+
+        QStandardPaths::setTestModeEnabled(true);
+        // Create directories used in test, since Qt doesn't create its automatically
+        QDir().mkpath(QStandardPaths::writableLocation(QStandardPaths::StateLocation));
+        QDir().mkpath(QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation));
+
+        _account = Account::create();
+        AccountManager::instance()->addAccount(_account);
+        oldCookieJarPath = QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation) + "/cookies" + _account->id() + ".db";
+    }
+    void testNoAction()
+    {
+        QFile jarFile(_account->cookieJarPath());
+        jarFile.open(QFile::WriteOnly);
+        jarFile.write("1", 1); // Write one byte to file
+        jarFile.close();
+        _account->tryMigrateCookieJar();
+
+        QVERIFY(!QFile::exists(oldCookieJarPath)); // Check that old file doesn't exits
+        QCOMPARE(QFileInfo(_account->cookieJarPath()).size(), 1); // Check that this byte present in new file
+        QFile::remove(_account->cookieJarPath()); // Cleanup
+    }
+    void testSimpleMigration()
+    {
+        QFile oldJarFile(oldCookieJarPath);
+        oldJarFile.open(QFile::WriteOnly);
+        oldJarFile.write("1", 1); // Write one byte to file
+        oldJarFile.close();
+
+        _account->tryMigrateCookieJar();
+        QVERIFY(!QFile::exists(oldCookieJarPath)); // Check that old file is deleted
+
+        QCOMPARE(QFileInfo(_account->cookieJarPath()).size(), 1); // Check that this byte present in new file
+        QFile::remove(_account->cookieJarPath()); // Cleanup
+    }
+    void testNotOverwrite()
+    {
+        QFile oldJarFile(oldCookieJarPath);
+        oldJarFile.open(QFile::WriteOnly);
+        oldJarFile.write("1", 1); // Write one byte to file
+        oldJarFile.close();
+
+        QFile newJarFile(_account->cookieJarPath());
+        oldJarFile.open(QFile::WriteOnly);
+        oldJarFile.write("123", 3); // Write three bytes to file
+        oldJarFile.close();
+
+
+        _account->tryMigrateCookieJar();
+
+        QCOMPARE(QFileInfo(_account->cookieJarPath()).size(), 3); // Check that these bytes still present
+
+        // Cleanup
+        QFile::remove(_account->cookieJarPath());
+        QFile::remove(oldCookieJarPath);
+    }
+};
+
+QTEST_APPLESS_MAIN(TestCookieJarMigration)
+#include "testcookiejarmigration.moc"