Chaning directories for logs and state files

[brainrom]

Fix for #3406 and #7654.

And cookie jar now also stores in StateLocation, because it's app state and not configuration. Added corresponding migration function.

Shouldn't negatively affect Windows and Mac OS, because StateLocation on these platforms are subdirectories of AppConfigLocation.

From Qt doc:

Path type	macOS	Windows
AppConfigLocation	"~/Library/Preferences/<APPNAME>"	"C:/Users/<USER>/AppData/Local/<APPNAME>", "C:/ProgramData/<APPNAME>"
StateLocation	"~/Library/Preferences/<APPNAME>/State"	"C:/Users/<USER>/AppData/Local/<APPNAME>/State", "C:/ProgramData/<APPNAME>/State"

[camilasan]

Shouldn't negatively affect Windows and Mac OS, because StateLocation on these platforms are subdirectories of AppConfigLocation.

Do you have access to Mac and/or Windows to check it?
Could you try adding testing for this change?

[brainrom]

Do you have access to Mac and/or Windows to check it?

I can try build and check on Windows, but have absolutely no idea how to build and check on Mac.

Could you try adding testing for this change?

What kind of testing?

[camilasan]

I can try build and check on Windows, but have absolutely no idea how to build and check on Mac.

On Windows it would already help.

What kind of testing?

Sorry, I mean tests. Unit/code tests.

[brainrom]

On Windows it would already help.

Ok, then I'll manually test it on Windows.

Sorry, I mean tests. Unit/code tests.

Nextcloud currently don't have tests for similar things, not configs, nor migration. What exactly should I test? I can make test for tryMigrateCookieJar() method. Create file in old location, test that it moves to the new location, etc.
Btw, should migration overwrite new file in case where old file and new file presents?

[camilasan]

Sorry I didn't reply before...

I can make test for tryMigrateCookieJar() method. Create file in old location, test that it moves to the new location, etc.

That makes sense.

Btw, should migration overwrite new file in case where old file and new file presents?

You should check if there is a file present before migrating. That is what we do with the config file nextcloud.cfg.

[brainrom]

Now new file isn't overwritten if already exists. Added test for tryMigrateCookieJar().

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[mgallien]

@brainrom what would happen if we now write the logs to a different folder, what do you do with existing log files ?
are they moved to the new folder ?
can you check if generating a debug archive is still working ?

[brainrom]

I checked log generation on Linux, it records to ~/.local/state/logs. On MacOS and Windows it should work, because it uses write location and create dirs if it doesn't exist, but I'm unable to test it.

[mgallien]

@brainrom you cannot change the log location without the migration (as you did with the cookie jar)
see also my other comments

[mgallien]

before we change the log location, existing log files should be migrated to the new place
otherwise people may loose logs that may be important for them

[brainrom]

Is Application::setupLogging() is the good place for log migration routine? Looks like it's entry point for logDir() usage.

[mgallien]

@brainrom
yes
I think so
sorry for the delay