Skip to content

chore: document that threshold should stay the same during refresh #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

chore: document that threshold should stay the same during refresh #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ba2a7
chore: document that threshold should stay the same during refresh
gilcu3 Nov 17, 2025
a5fb55a
fix: typo and use public link instead
gilcu3 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/crypto/polynomials.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ impl<C: Ciphersuite> Polynomial<C> {
})
}

/// Returns the coeficients of the polynomial
/// Returns the coefficients of the polynomial
pub fn get_coefficients(&self) -> Vec<Scalar<C>> {
self.coefficients.clone()
}
Expand Down
2 changes: 2 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ where
)));
}
let comms = Comms::new();
// NOTE: this equality must be kept, as changing the threshold during `key refresh`
// might lead to insecure scenarios. For more information see https://github.com/ZcashFoundation/frost/security/advisories/GHSA-wgq8-vr6r-mqxm
let threshold = old_threshold;
let (participants, old_participants) = reshare_assertions::<C>(
old_participants,
Expand Down