Skip to content

Conversation

@gilcu3
Copy link
Contributor

@gilcu3 gilcu3 commented Nov 17, 2025

Closes #57

  • After reading carefully the auditor's advice, and the original fix for a similar problem in frost, I think the only thing we can do here is adding a comment for future developers, as the current implementation already guarantees the invariant.

@gilcu3 gilcu3 linked an issue Nov 17, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.93%. Comparing base (1e03b9c) to head (a5fb55a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   87.92%   87.93%           
=======================================
  Files          41       41           
  Lines        9046     9048    +2     
  Branches     9046     9048    +2     
=======================================
+ Hits         7954     7956    +2     
  Misses        645      645           
  Partials      447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimonRastikian
Copy link
Contributor

This is good. Although I was thinking more of also adding this to the readme

@gilcu3
Copy link
Contributor Author

gilcu3 commented Nov 19, 2025

This is good. Although I was thinking more of also adding this to the readme

That would be a bit strange, as the function cannot be called with two thresholds anyway :)

@gilcu3 gilcu3 merged commit 03fd501 into main Nov 19, 2025
3 checks passed
@gilcu3 gilcu3 deleted the 57-prevent-doing-key-refresh-while-changing-the-threshold branch November 19, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent the possibility of changing the threshold during Key Refresh

6 participants