-
Notifications
You must be signed in to change notification settings - Fork 0
feat: show refresh and back button is pwa mode #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: eval-pr-23838-target-1757934516453
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
| ], | ||
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing the PWA display mode to Prompt for AI agents[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change introduces a functional regression. The "Add to Homescreen" prompt will now incorrectly appear for users who have already installed the PWA. The component at Prompt for AI agents[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing to "minimal-ui" without a defined fallback reduces cross-browser resilience; consider using manifest "display_override" to prefer minimal-ui while falling back to standalone to preserve app-like UX where needed. Prompt for AI agents[internal] Confidence score: 8/10 [internal] Posted by: General AI Review Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Manifest display set to minimal-ui without display_override causes fallback to browser on many UAs, breaking PWA install/standalone behavior. Prompt for AI agents[internal] Confidence score: 8/10 [internal] Posted by: Functional Bugs Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing the PWA display mode to Prompt for AI agents[internal] Confidence score: 10/10 [internal] Posted by: System Design Agent There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changing the manifest Prompt for AI agents[internal] Confidence score: 9/10 [internal] Posted by: General AI Review Agent |
||
| "scope": "/", | ||
| "start_url": "/" | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a redundant back button. The app already provides a custom back button component in its main layout (
ShellMainAppDirBackButton). Switching the PWAdisplaymode tominimal-uiwill enable the browser's native back button, resulting in two back buttons being displayed on many pages, creating a confusing user experience.Reasoning:
• GPT-5: Speculative and platform-dependent. minimal-ui controls vary by OS/browser and the duplication with the in-app back button is an intentional product choice per this PR. Not a clear, high-confidence technical bug or severity issue.
• Libraries consulted: Web App Manifest display minimal-ui MDN, Content
Prompt for AI agents
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent