feat: show refresh and back button is pwa mode #9
Conversation
this shows the refresh and back button for easier navigation ux
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 1 file
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
This change introduces a redundant back button. The app already provides a custom back button component in its main layout (`ShellMainAppDirBackButton`). Switching the PWA `display` mode to `minimal-ui` will enable the browser's native back button, resulting in two back buttons being displayed on many pages, creating a confusing user experience.
DEV MODE: This violation would have been filtered out by GPT-5.
Reasoning:
• **GPT-5**: Speculative and platform-dependent. minimal-ui controls vary by OS/browser and the duplication with the in-app back button is an intentional product choice per this PR. Not a clear, high-confidence technical bug or severity issue.
• **Libraries consulted**: Web App Manifest display minimal-ui MDN, Content</violation>
<violation number="2" location="apps/web/public/site.webmanifest:19">
Changing the PWA display mode to `minimal-ui` breaks the logic in the `AddToHomescreen` component, which will now incorrectly display the 'Add to Homescreen' banner within the installed PWA. The component explicitly checks for `display-mode: standalone` to hide itself and does not account for `minimal-ui`.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
This change introduces a redundant back button. The app already provides a custom back button component in its main layout (ShellMainAppDirBackButton). Switching the PWA display mode to minimal-ui will enable the browser's native back button, resulting in two back buttons being displayed on many pages, creating a confusing user experience.
DEV MODE: This violation would have been filtered out by GPT-5.
Reasoning:
• GPT-5: Speculative and platform-dependent. minimal-ui controls vary by OS/browser and the duplication with the in-app back button is an intentional product choice per this PR. Not a clear, high-confidence technical bug or severity issue.
• Libraries consulted: Web App Manifest display minimal-ui MDN, Content
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>This change introduces a redundant back button. The app already provides a custom back button component in its main layout (`ShellMainAppDirBackButton`). Switching the PWA `display` mode to `minimal-ui` will enable the browser's native back button, resulting in two back buttons being displayed on many pages, creating a confusing user experience.
DEV MODE: This violation would have been filtered out by GPT-5.
Reasoning:
• **GPT-5**: Speculative and platform-dependent. minimal-ui controls vary by OS/browser and the duplication with the in-app back button is an intentional product choice per this PR. Not a clear, high-confidence technical bug or severity issue.
• **Libraries consulted**: Web App Manifest display minimal-ui MDN, Content</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
Changing the PWA display mode to minimal-ui breaks the logic in the AddToHomescreen component, which will now incorrectly display the 'Add to Homescreen' banner within the installed PWA. The component explicitly checks for display-mode: standalone to hide itself and does not account for minimal-ui.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>Changing the PWA display mode to `minimal-ui` breaks the logic in the `AddToHomescreen` component, which will now incorrectly display the 'Add to Homescreen' banner within the installed PWA. The component explicitly checks for `display-mode: standalone` to hide itself and does not account for `minimal-ui`.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
This change introduces a functional regression. The "Add to Homescreen" prompt will now incorrectly appear for users who have already installed the PWA. The component at `apps/web/components/AddToHomescreen.tsx` only checks for `display-mode: standalone` to hide the prompt, but this PR changes the display mode to `minimal-ui`.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
This change introduces a functional regression. The "Add to Homescreen" prompt will now incorrectly appear for users who have already installed the PWA. The component at apps/web/components/AddToHomescreen.tsx only checks for display-mode: standalone to hide the prompt, but this PR changes the display mode to minimal-ui.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>This change introduces a functional regression. The "Add to Homescreen" prompt will now incorrectly appear for users who have already installed the PWA. The component at `apps/web/components/AddToHomescreen.tsx` only checks for `display-mode: standalone` to hide the prompt, but this PR changes the display mode to `minimal-ui`.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent
![cubic-staging[bot]](https://avatars.githubusercontent.com/u/189440881?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
Changing to "minimal-ui" without a defined fallback reduces cross-browser resilience; consider using manifest "display_override" to prefer minimal-ui while falling back to standalone to preserve app-like UX where needed.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
Changing to "minimal-ui" without a defined fallback reduces cross-browser resilience; consider using manifest "display_override" to prefer minimal-ui while falling back to standalone to preserve app-like UX where needed.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>Changing to "minimal-ui" without a defined fallback reduces cross-browser resilience; consider using manifest "display_override" to prefer minimal-ui while falling back to standalone to preserve app-like UX where needed.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 8/10
[internal] Posted by: General AI Review Agent
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
Manifest display set to minimal-ui without display_override causes fallback to browser on many UAs, breaking PWA install/standalone behavior.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
Manifest display set to minimal-ui without display_override causes fallback to browser on many UAs, breaking PWA install/standalone behavior.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>Manifest display set to minimal-ui without display_override causes fallback to browser on many UAs, breaking PWA install/standalone behavior.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 8/10
[internal] Posted by: Functional Bugs Agent
|
This PR is being marked as stale due to inactivity. |
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
Changing the PWA display mode to `minimal-ui` causes the 'Add to Home Screen' banner to be displayed incorrectly. The logic in `AddToHomescreen.tsx` only checks for `standalone` mode and needs to be updated to also check for `minimal-ui` to prevent the banner from showing when the app is already installed.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
Changing the PWA display mode to minimal-ui causes the 'Add to Home Screen' banner to be displayed incorrectly. The logic in AddToHomescreen.tsx only checks for standalone mode and needs to be updated to also check for minimal-ui to prevent the banner from showing when the app is already installed.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>Changing the PWA display mode to `minimal-ui` causes the 'Add to Home Screen' banner to be displayed incorrectly. The logic in `AddToHomescreen.tsx` only checks for `standalone` mode and needs to be updated to also check for `minimal-ui` to prevent the banner from showing when the app is already installed.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 10/10
[internal] Posted by: System Design Agent
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/web/public/site.webmanifest">
<violation number="1" location="apps/web/public/site.webmanifest:19">
Changing the manifest `display` value to `minimal-ui` regresses the installed PWA experience—major browsers (e.g., Chrome, Edge) do not support `minimal-ui` and fall back to `browser`, so the app will reopen with the full browser UI instead of the standalone window users currently get.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| "theme_color": "#ffffff", | ||
| "background_color": "#ffffff", | ||
| "display": "standalone", | ||
| "display": "minimal-ui", |
There was a problem hiding this comment.
Changing the manifest display value to minimal-ui regresses the installed PWA experience—major browsers (e.g., Chrome, Edge) do not support minimal-ui and fall back to browser, so the app will reopen with the full browser UI instead of the standalone window users currently get.
Prompt for AI agents
Address the following comment on apps/web/public/site.webmanifest at line 19:
<comment>Changing the manifest `display` value to `minimal-ui` regresses the installed PWA experience—major browsers (e.g., Chrome, Edge) do not support `minimal-ui` and fall back to `browser`, so the app will reopen with the full browser UI instead of the standalone window users currently get.</comment>
<file context>
@@ -16,7 +16,7 @@
"theme_color": "#ffffff",
"background_color": "#ffffff",
- "display": "standalone",
+ "display": "minimal-ui",
"scope": "/",
"start_url": "/"
</file context>
[internal] Confidence score: 9/10
[internal] Posted by: General AI Review Agent
cubic is running your AI reviewPipeline
|
cubic is running your AI reviewPipeline
|
1 participant
this shows the refresh and back button for easier navigation ux
What does this PR do?
adds a refresh and a back button for easier navigation ux
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
before
after
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Switch PWA display mode from standalone to minimal-ui to show native Back and Refresh buttons. Improves navigation in the installed app without changing scope or start_url.