Skip to content

Fix: Robust netsh output parsing for Add-SslCert for Windows Server 2… #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix: Robust netsh output parsing for Add-SslCert for Windows Server 2… #1253

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c40fef1
Fix: Robust netsh output parsing for Add-SslCert for Windows Server 2…
1000986-PHS Jun 18, 2025
b2b4bc5
Merge branch 'master' into fix-netsh-parsing-win2022
1000986-PHS Jul 15, 2025
f5eb8d1
Merge branch 'master' into fix-netsh-parsing-win2022
1000986-PHS Jul 17, 2025
a3c06a9
Merge branch 'master' into fix-netsh-parsing-win2022
1000986-PHS Jul 25, 2025
6745028
Merge branch 'master' into fix-netsh-parsing-win2022
1000986-PHS Aug 29, 2025
8281c5e
Merge branch 'master' into fix-netsh-parsing-win2022
1000986-PHS Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 32 additions & 46 deletions TaskModules/powershell/TaskModuleIISManageUtility/AppCmdOnTargetMachines.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,19 @@ function Enable-SNI
Invoke-VstsTool -Filename $appCmdPath -Arguments $appCmdArgs -RequireExitCodeZero
}

function Get-NetshFieldValue {
param(
[array]$netshResult,
[string]$fieldName
)
foreach ($line in $netshResult) {
if ($line -match "^\s*${fieldName}\s*:\s*(.+)$") {
return $matches[1].Trim()
}
}
return $null
}

function Add-SslCert
{
param(
Expand All @@ -161,77 +174,50 @@ function Add-SslCert
[string]$ipAddress
)

if([string]::IsNullOrWhiteSpace($certhash))
{
if([string]::IsNullOrWhiteSpace($certhash)) {
Write-Verbose "CertHash is empty. Returning"
return
}

if($ipAddress -eq "All Unassigned" -or $ipAddress -eq "*")
{
if($ipAddress -eq "All Unassigned" -or $ipAddress -eq "*") {
$ipAddress = "0.0.0.0"
}

$result = $null
$isItSameBinding = $false
$isItSameCert = $false
$addCertCmd = [string]::Empty

#SNI is supported IIS 8 and above. To enable SNI hostnameport option should be used
if($sni -eq "true" -and $iisVersion -ge 8 -and -not [string]::IsNullOrWhiteSpace($hostname))
{
if($sni -eq "true" -and $iisVersion -ge 8 -and -not [string]::IsNullOrWhiteSpace($hostname)) {
$showCertCmd = [string]::Format("http show sslcert hostnameport={0}:{1}", $hostname, $port)
Write-Verbose "Checking if SslCert binding is already present. Running command : netsh $showCertCmd"

$result = Invoke-VstsTool -Filename "netsh" -Arguments $showCertCmd
$bindingPattern = "Hostname:port\s*:\s*([^:\s]+):(\d+)"
$certHashPattern = "Certificate Hash\s*:\s*([a-fA-F0-9]+)"

$resultText = $result -join "`n"

if($resultText -match $bindingPattern)
{
$extractedHostname = $matches[1]
$extractedPort = $matches[2]
$isItSameBinding = ($extractedHostname -eq $hostname -and $extractedPort -eq $port)
}

if($resultText -match $certHashPattern)
{
$extractedCertHash = $matches[1]
$isItSameCert = ($extractedCertHash.ToLower() -eq $certhash.ToLower())
}

$actualBinding = Get-NetshFieldValue $result "Hostname:port"
$actualCertHash = Get-NetshFieldValue $result "Certificate Hash"

$isItSameBinding = $actualBinding -and $actualBinding.ToLower() -eq ("{0}:{1}" -f $hostname, $port).ToLower()
$isItSameCert = $actualCertHash -and $actualCertHash.ToLower().Contains($certhash.ToLower())

$addCertCmd = [string]::Format("http add sslcert hostnameport={0}:{1} certhash={2} appid={{{3}}} certstorename=MY", $hostname, $port, $certhash, [System.Guid]::NewGuid().toString())
}
else
{
else {
$showCertCmd = [string]::Format("http show sslcert ipport={0}:{1}", $ipAddress, $port)
Write-Verbose "Checking if SslCert binding is already present. Running command : netsh $showCertCmd"

$result = Invoke-VstsTool -Filename "netsh" -Arguments $showCertCmd
$bindingPattern = "IP:port\s*:\s*([^:\s]+):(\d+)"
$certHashPattern = "Certificate Hash\s*:\s*([a-fA-F0-9]+)"

$resultText = $result -join "`n"

if($resultText -match $bindingPattern)
{
$extractedIP = $matches[1]
$extractedPort = $matches[2]
$isItSameBinding = ($extractedIP -eq $ipAddress -and $extractedPort -eq $port)
}

if($resultText -match $certHashPattern)
{
$extractedCertHash = $matches[1]
$isItSameCert = ($extractedCertHash.ToLower() -eq $certhash.ToLower())
}


$actualBinding = Get-NetshFieldValue $result "IP:port"
$actualCertHash = Get-NetshFieldValue $result "Certificate Hash"

$isItSameBinding = $actualBinding -and $actualBinding.ToLower() -eq ("{0}:{1}" -f $ipAddress, $port).ToLower()
$isItSameCert = $actualCertHash -and $actualCertHash.ToLower().Contains($certhash.ToLower())

$addCertCmd = [string]::Format("http add sslcert ipport={0}:{1} certhash={2} appid={{{3}}} certstorename=MY", $ipAddress, $port, $certhash, [System.Guid]::NewGuid().toString())
}

if($isItSameBinding -and $isItSameCert)
{
if($isItSameBinding -and $isItSameCert) {
Write-Verbose "SSL cert binding is already present. Returning"
return
}
Expand Down