Fix: Robust netsh output parsing for Add-SslCert for Windows Server 2… #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…022+ compatibility Use field-name-based parsing for netsh output in Add-SslCert, ensuring compatibility with Windows Server 2022 and future versions. The prior version used indexes and would fail with Windows Server 2022.
|
@microsoft-github-policy-service agree company="ProMedica" |
|
@LeftTwixWand and @ivanduplenskikh You two seem to successfully complete PRs here. What do I need to do to move this along? This bug has prevented my organization from being able to deploy to Windows Server 2022 for many years now. As a workaround I've had to manually fix the bug with every agent myself but that's tedious as every update to the agents could push the broken version again. |
|
Any updates regarding this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…022+ compatibility
Description: The prior version used indexes when parsing netsh output and would fail with Windows Server 2022. The new version uses field-name-based parsing for netsh output in Add-SslCert to ensure compatibility with Windows Server 2022 and future versions.
The one thing I didn't see was if there was a version number somewhere that needed bumped.
Documentation changes required: (N)
Added unit tests: (N)
Attached related issue: (Y) #1039 #1008 #919 #1058 #862
Checklist: