Add volume snapshots support to vcluster snapshot create command
#3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
26b3f0f to
18be504
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
41ea8c3 to
cf0bc84
Compare
jjaferson
reviewed
Sep 15, 2025
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
18be504 to
1cd1248
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
cf0bc84 to
24e6890
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
1cd1248 to
9deeceb
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
24e6890 to
62cdfcd
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
481ec17 to
56e4ec4
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
b8172d2 to
0636810
Compare
Base automatically changed from
feature/snapshot-controller/add-volume-snapshots-module
to
main
September 17, 2025 08:48
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
52dd43d to
1566aa4
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
857c0f3 to
f59a621
Compare
jjaferson
reviewed
Sep 25, 2025
jjaferson
reviewed
Sep 25, 2025
FabianKramm
reviewed
Sep 26, 2025
FabianKramm
requested changes
Sep 26, 2025
jjaferson
reviewed
Sep 26, 2025
jjaferson
reviewed
Sep 26, 2025
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
67cbbfb to
28cfed5
Compare
jjaferson
reviewed
Sep 29, 2025
nprokopic
force-pushed
the
feature/snapshot-controller/create-volume-snapshots
branch
from
e1bf90b to
ed1ca01
Compare
FabianKramm
approved these changes
Sep 30, 2025
FabianKramm
deleted the
feature/snapshot-controller/create-volume-snapshots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)closes ENG-7763, ENG-5938, ENG-9121, ENG-8836
Please provide a short message that should be published in the vcluster release notes
Add volume snapshots support to
vcluster snapshot createandvcluster restorecommand.What else do we need to know?
This PR adds support for creating volume snapshots and restoring volumes for vCluster with shared and private nodes. Support for standalone will be added in one of the subsequent PRs.
Remaining TODOs:
autovalue (enabled with shared nodes, disabled with private nodes)Clean up VolumeSnapshot and VolumeSnapshotContent resources that vCluster creates when creating snapshots and restoring volumesCreated issue ENG-9271 for this.Add e2e tests(will be added in another PR)