Upgrade upstream volume snapshots client module to v8 #3200
+2,633
−289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
75b02fd to
26b3f0f
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/upstream-snapshot-controller
branch
from
2b58994 to
43c2d88
Compare
3 tasks
nprokopic
force-pushed
the
feature/snapshot-controller/upstream-snapshot-controller
branch
from
43c2d88 to
7c57519
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
26b3f0f to
18be504
Compare
jjaferson
previously approved these changes
Sep 15, 2025
nprokopic
force-pushed
the
feature/snapshot-controller/upstream-snapshot-controller
branch
from
7c57519 to
535705f
Compare
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
18be504 to
1cd1248
Compare
Base automatically changed from
feature/snapshot-controller/upstream-snapshot-controller
to
main
September 16, 2025 13:46
FabianKramm
dismissed
jjaferson’s stale review
The base branch was changed.
nprokopic
force-pushed
the
feature/snapshot-controller/add-volume-snapshots-module
branch
from
1cd1248 to
9deeceb
Compare
jjaferson
previously approved these changes
Sep 16, 2025
FabianKramm
reviewed
Sep 16, 2025
FabianKramm
requested changes
Sep 16, 2025
There was a problem hiding this comment.
@nprokopic we already have v4 as a dependency and I don't like that now we have two different versions as a dependency, either use v4 or upgrade the existing stuff to use v8 as well
nprokopic
changed the title
Upgraded everything to use just v8, and completely removed v4. |
jjaferson
approved these changes
Sep 17, 2025
FabianKramm
approved these changes
Sep 17, 2025
FabianKramm
deleted the
feature/snapshot-controller/add-volume-snapshots-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)towards ENG-7763 and ENG-5938
What else do we need to know?