Skip to content

LCORE-385: Reduce response quantity in streaming_query #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

LCORE-385: Reduce response quantity in streaming_query #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4af1c97
Refactor inference event handling in streaming_query.py to streamline…
jrobertboos Aug 1, 2025
dd05918
Fixing CI checks
jrobertboos Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 6 additions & 53 deletions src/app/endpoints/streaming_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
from llama_stack_client.types import UserMessage # type: ignore

from llama_stack_client.lib.agents.event_logger import interleaved_content_as_str
from llama_stack_client.types.shared import ToolCall
from llama_stack_client.types.shared.interleaved_content_item import TextContentItem

from fastapi import APIRouter, HTTPException, Request, Depends, status
Expand Down Expand Up @@ -256,55 +255,21 @@ def _handle_shield_event(chunk: Any, chunk_id: int) -> Iterator[str]:
# Inference handling
# -----------------------------------
def _handle_inference_event(chunk: Any, chunk_id: int) -> Iterator[str]:
if chunk.event.payload.event_type == "step_start":
if (
chunk.event.payload.event_type == "step_progress"
and chunk.event.payload.delta.type == "text"
):
yield format_stream_data(
{
"event": "token",
"data": {
"id": chunk_id,
"role": chunk.event.payload.step_type,
"token": "",
"token": chunk.event.payload.delta.text,
},
}
)

elif chunk.event.payload.event_type == "step_progress":
if chunk.event.payload.delta.type == "tool_call":
if isinstance(chunk.event.payload.delta.tool_call, str):
yield format_stream_data(
{
"event": "tool_call",
"data": {
"id": chunk_id,
"role": chunk.event.payload.step_type,
"token": chunk.event.payload.delta.tool_call,
},
}
)
elif isinstance(chunk.event.payload.delta.tool_call, ToolCall):
yield format_stream_data(
{
"event": "tool_call",
"data": {
"id": chunk_id,
"role": chunk.event.payload.step_type,
"token": chunk.event.payload.delta.tool_call.tool_name,
},
}
)

elif chunk.event.payload.delta.type == "text":
yield format_stream_data(
{
"event": "token",
"data": {
"id": chunk_id,
"role": chunk.event.payload.step_type,
"token": chunk.event.payload.delta.text,
},
}
)


# -----------------------------------
# Tool Execution handling
Expand All @@ -313,19 +278,7 @@ def _handle_inference_event(chunk: Any, chunk_id: int) -> Iterator[str]:
def _handle_tool_execution_event(
chunk: Any, chunk_id: int, metadata_map: dict
) -> Iterator[str]:
if chunk.event.payload.event_type == "step_start":
yield format_stream_data(
{
"event": "tool_call",
"data": {
"id": chunk_id,
"role": chunk.event.payload.step_type,
"token": "",
},
}
)

elif chunk.event.payload.event_type == "step_complete":
if chunk.event.payload.event_type == "step_complete":
for t in chunk.event.payload.step_details.tool_calls:
yield format_stream_data(
{
Expand Down
18 changes: 4 additions & 14 deletions tests/unit/app/endpoints/test_streaming_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,14 +860,9 @@ def test_stream_build_event_step_progress_tool_call_str():
)
)

result = next(stream_build_event(chunk, 0, {}))
results = list(stream_build_event(chunk, 0, {}))

assert result is not None
assert "data: " in result
assert '"event": "tool_call"' in result
assert '"token": "tool-called"' in result
assert '"role": "inference"' in result
assert '"id": 0' in result
assert len(results) == 0


def test_stream_build_event_step_progress_tool_call_tool_call():
Expand All @@ -892,14 +887,9 @@ def test_stream_build_event_step_progress_tool_call_tool_call():
)
)

result = next(stream_build_event(chunk, 0, {}))
results = list(stream_build_event(chunk, 0, {}))

assert result is not None
assert "data: " in result
assert '"event": "tool_call"' in result
assert '"token": "my-tool"' in result
assert '"role": "inference"' in result
assert '"id": 0' in result
assert len(results) == 0


def test_stream_build_event_step_complete():
Expand Down
Loading