-
Notifications
You must be signed in to change notification settings - Fork 49
LCORE-385: Reduce response quantity in streaming_query #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… token processing and remove redundant tool call logic. Update unit tests to reflect changes in event handling and ensure correct assertions.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@TamiTakamiya Do you foresee any issues with this PR?
|
@jrobertboos can you share an example output with this change? |
I think it should be fine as long as |
Description
This PR removes the inference steps from tool calling as the used tools are streamed as tool_execution steps making the inference steps redundant. If anyone has any issues with this please let it be known 😄. I did this in order to make the streamed responses more human readable.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing