Add WatchtowerClient interface #235
Conversation
Jontified
force-pushed
the
master
branch
2 times, most recently
from
f11e493 to
4a32fb0
Compare
|
This PR should be ready for review now. This |
Thank you for this contribution 👍. I took an initial look and the approach looks good. Could you please change your commit structure such that it complies with the dev guidelines (see https://github.com/lightningnetwork/lnd/blob/master/docs/development_guidelines.md)? Specifically, squashing your commits to only contain the essential operations (1. adding the interface/implementation, 2. change of the server name parsing, 3. adding the service). I'd take another look afterwards. |
OK! Commit structure should be good now! |
Use strings.TrimSuffix instead of strings.ReplaceAll in the macaroon recipe code. This is necessary because the WtClient macaroon name contains the word "client" and would be malformed in the old code. New code just removes the last "client". Signed-off-by: Jonathan <[email protected]>
Add the wtclient_client.go file which contains the lnd watchtower client interface. Signed-off-by: Jonathan <[email protected]>
Add the watchtower client service to the macaroon recipe and to the main lnd services.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.
This PR adds the WatchtowerClient interface. The reason for adding this is so that it can be used in
lndmonin a way described here: lightninglabs/lndmon#118