Use strings.TrimSuffix instead of replaceRight

Author: Jontified

macaroon_recipes.go

@@ -55,15 +55,6 @@ var (
 	}
 )
 
-func replaceRight(s, oldString, newString string) string {
-	i := strings.LastIndex(s, oldString)
-	if i == -1 {
-		return s
-	}
-
-	return s[:i] + newString + s[i+len(oldString):]
-}
-
 // MacaroonRecipe returns a list of macaroon permissions that is required to use
 // the full feature set of the given list of RPC package names.
 func MacaroonRecipe(c LightningClient, packages []string) ([]MacaroonPermission,
@@ -87,7 +78,7 @@ func MacaroonRecipe(c LightningClient, packages []string) ([]MacaroonPermission,
 		// From the pointer type we can find out the interface, its name
 		// and what methods it declares.
 		ifaceType := reflect.TypeOf(ifacePtr).Elem()
-		serverName := replaceRight(ifaceType.Name(), "Client", "")
+		serverName := strings.TrimSuffix(ifaceType.Name(), "Client")
 		for i := range ifaceType.NumMethod() {
 			// The methods in lndclient might be called slightly
 			// differently. Rename according to our rename mapping