Skip to content

conformance: add Hook in ConformanceTestSuite #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

conformance: add Hook in ConformanceTestSuite #3786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions conformance/utils/suite/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ type ConformanceTestSuite struct {
SkipTests sets.Set[string]
SkipProvisionalTests bool
RunTest string
Hook func(t *testing.T, test ConformanceTest, suite *ConformanceTestSuite)
ManifestFS []fs.FS
UsableNetworkAddresses []v1beta1.GatewaySpecAddress
UnusableNetworkAddresses []v1beta1.GatewaySpecAddress
Expand Down Expand Up @@ -470,6 +471,13 @@ func (suite *ConformanceTestSuite) Run(t *testing.T, tests []ConformanceTest) er
if res == testSucceeded || res == testFailed {
sleepForTestIsolation = true
}

// call the hook function if it was provided,
// this's useful for running custom logic after each test,
// such as collecting current state of the cluster for debugging.
if suite.Hook != nil {
suite.Hook(t, test, suite)
}
}

// now that the tests have completed, mark the test suite as not running
Expand Down