Skip to content

conformance: add Hook in ConformanceTestSuite #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented May 11, 2025

What type of PR is this?

/kind feature
/kind test
/area conformance-test

What this PR does / why we need it:

Add hook points support in conformance test suite

Which issue(s) this PR fixes:

Fixes #3131

Does this PR introduce a user-facing change?:

Add hook points support in conformance test suite

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/test area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2025
@arkodg
Copy link
Contributor

arkodg commented May 12, 2025

/approve thanks !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@youngnick
Copy link
Contributor

I think this is okay, as it only runs after the test has been completed. It's super important that we don't allow hooks before, as we don't want the behavior of the conformance tests to be able to be modified (or else we can't be sure that the same behavior is executed for every implementation, defeating the point of conformance).

I won't LGTM though, as I'd like @mlavacca to confirm he's okay with this. Holding for his review.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@zirain
Copy link
Contributor Author

zirain commented May 12, 2025

I want to clearify that, we want this to run dump function for debugging a flaky test.
That's why this was only added to post-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. kind/test release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hook points support in conformance test suite
4 participants