-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(controller-gen): move tools under go tools #5878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivankatliarchuk
wants to merge
13
commits into
kubernetes-sigs:master
Choose a base branch
from
gofogo:chore-move-crd-to-tools
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+518
−59
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
efb586d
chore(controller-gen): move tools under go tools
ivankatliarchuk 779b59f
chore(controller-gen): move tools under go tools
ivankatliarchuk 60431f5
chore(controller-gen): move tools under go tools
ivankatliarchuk eb2d429
chore(controller-gen): move tools under go tools
ivankatliarchuk d67a844
chore(controller-gen): move tools under go tools
ivankatliarchuk 951cd6a
chore(controller-gen): move tools under go tools
ivankatliarchuk 778761a
chore(controller-gen): move tools under go tools
ivankatliarchuk debfaff
chore(controller-gen): move tools under go tools
ivankatliarchuk b27f4ae
chore(controller-gen): move tools under go tools
ivankatliarchuk 42a11ff
chore(controller-gen): move tools under go tools
ivankatliarchuk e923c13
chore(controller-gen): move tools under go tools
ivankatliarchuk b0c7722
chore(controller-gen): move tools under go tools
ivankatliarchuk 4fe8557
chore(controller-gen): move tools under go tools
ivankatliarchuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
module sigs.k8s.io/external-dns/tools | ||
|
||
go 1.25 | ||
|
||
tool ( | ||
github.com/google/yamlfmt/cmd/yamlfmt | ||
github.com/mikefarah/yq/v4 | ||
sigs.k8s.io/controller-tools/cmd/controller-gen | ||
) | ||
|
||
require ( | ||
github.com/a8m/envsubst v1.4.3 // indirect | ||
github.com/alecthomas/chroma/v2 v2.20.0 // indirect | ||
github.com/alecthomas/participle/v2 v2.1.4 // indirect | ||
github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect | ||
github.com/aymerick/douceur v0.2.0 // indirect | ||
github.com/bahlo/generic-list-go v0.2.0 // indirect | ||
github.com/bmatcuk/doublestar/v4 v4.7.1 // indirect | ||
github.com/buger/jsonparser v1.1.1 // indirect | ||
github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
github.com/charmbracelet/bubbles/v2 v2.0.0-beta.1 // indirect | ||
github.com/charmbracelet/bubbletea/v2 v2.0.0-beta.4 // indirect | ||
github.com/charmbracelet/colorprofile v0.3.2 // indirect | ||
github.com/charmbracelet/glamour v0.10.0 // indirect | ||
github.com/charmbracelet/harmonica v0.2.0 // indirect | ||
github.com/charmbracelet/lipgloss v1.1.1-0.20250404203927-76690c660834 // indirect | ||
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.3 // indirect | ||
github.com/charmbracelet/x/ansi v0.10.1 // indirect | ||
github.com/charmbracelet/x/cellbuf v0.0.14-0.20250505150409-97991a1f17d1 // indirect | ||
github.com/charmbracelet/x/exp/slice v0.0.0-20250327172914-2fdc97757edf // indirect | ||
github.com/charmbracelet/x/input v0.3.7 // indirect | ||
github.com/charmbracelet/x/term v0.2.1 // indirect | ||
github.com/charmbracelet/x/windows v0.2.1 // indirect | ||
github.com/dimchansky/utfbom v1.1.1 // indirect | ||
github.com/dlclark/regexp2 v1.11.5 // indirect | ||
github.com/dop251/goja v0.0.0-20250630131328-58d95d85e994 // indirect | ||
github.com/dop251/goja_nodejs v0.0.0-20250409162600-f7acab6894b0 // indirect | ||
github.com/dustin/go-humanize v1.0.1 // indirect | ||
github.com/elliotchance/orderedmap v1.8.0 // indirect | ||
github.com/fatih/color v1.18.0 // indirect | ||
github.com/fsnotify/fsnotify v1.9.0 // indirect | ||
github.com/fxamacker/cbor/v2 v2.9.0 // indirect | ||
github.com/go-ini/ini v1.67.0 // indirect | ||
github.com/go-logr/logr v1.4.3 // indirect | ||
github.com/go-openapi/jsonpointer v0.21.0 // indirect | ||
github.com/go-openapi/jsonreference v0.20.2 // indirect | ||
github.com/go-openapi/swag v0.23.0 // indirect | ||
github.com/go-sourcemap/sourcemap v2.1.4+incompatible // indirect | ||
github.com/go-viper/mapstructure/v2 v2.4.0 // indirect | ||
github.com/gobuffalo/flect v1.0.3 // indirect | ||
github.com/goccy/go-json v0.10.5 // indirect | ||
github.com/goccy/go-yaml v1.18.0 // indirect | ||
github.com/gogo/protobuf v1.3.2 // indirect | ||
github.com/google/gnostic-models v0.7.0 // indirect | ||
github.com/google/go-cmp v0.7.0 // indirect | ||
github.com/google/pprof v0.0.0-20250501235452-c0086092b71a // indirect | ||
github.com/google/uuid v1.6.0 // indirect | ||
github.com/google/yamlfmt v0.17.2 // indirect | ||
github.com/gorilla/css v1.0.1 // indirect | ||
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect | ||
github.com/iancoleman/strcase v0.3.0 // indirect | ||
github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
github.com/jinzhu/copier v0.4.0 // indirect | ||
github.com/josharian/intern v1.0.0 // indirect | ||
github.com/json-iterator/go v1.1.12 // indirect | ||
github.com/lucasb-eyer/go-colorful v1.2.0 // indirect | ||
github.com/magiconair/properties v1.8.10 // indirect | ||
github.com/mailru/easyjson v0.7.7 // indirect | ||
github.com/mattn/go-colorable v0.1.14 // indirect | ||
github.com/mattn/go-isatty v0.0.20 // indirect | ||
github.com/mattn/go-runewidth v0.0.16 // indirect | ||
github.com/microcosm-cc/bluemonday v1.0.27 // indirect | ||
github.com/mikefarah/yq/v4 v4.47.2 // indirect | ||
github.com/mitchellh/mapstructure v1.5.0 // indirect | ||
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect | ||
github.com/muesli/cancelreader v0.2.2 // indirect | ||
github.com/muesli/reflow v0.3.0 // indirect | ||
github.com/muesli/termenv v0.16.0 // indirect | ||
github.com/pb33f/doctor v0.0.39 // indirect | ||
github.com/pb33f/jsonpath v0.1.2 // indirect | ||
github.com/pb33f/libopenapi v0.28.0 // indirect | ||
github.com/pb33f/libopenapi-validator v0.6.3 // indirect | ||
github.com/pb33f/ordered-map/v2 v2.3.0 // indirect | ||
github.com/pelletier/go-toml/v2 v2.2.4 // indirect | ||
github.com/petermattis/goid v0.0.0-20250508124226-395b08cebbdb // indirect | ||
github.com/pkg/errors v0.9.1 // indirect | ||
github.com/rivo/uniseg v0.4.7 // indirect | ||
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 // indirect | ||
github.com/sagikazarmark/locafero v0.11.0 // indirect | ||
github.com/santhosh-tekuri/jsonschema/v6 v6.0.2 // indirect | ||
github.com/sasha-s/go-deadlock v0.3.5 // indirect | ||
github.com/segmentio/ksuid v1.0.4 // indirect | ||
github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 // indirect | ||
github.com/sourcegraph/jsonrpc2 v0.2.0 // indirect | ||
github.com/spf13/afero v1.15.0 // indirect | ||
github.com/spf13/cast v1.10.0 // indirect | ||
github.com/spf13/cobra v1.10.1 // indirect | ||
github.com/spf13/pflag v1.0.10 // indirect | ||
github.com/spf13/viper v1.21.0 // indirect | ||
github.com/subosito/gotenv v1.6.0 // indirect | ||
github.com/tliron/commonlog v0.2.19 // indirect | ||
github.com/tliron/glsp v0.2.2 // indirect | ||
github.com/tliron/kutil v0.3.26 // indirect | ||
github.com/x448/float16 v0.8.4 // indirect | ||
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect | ||
github.com/yuin/goldmark v1.7.8 // indirect | ||
github.com/yuin/goldmark-emoji v1.0.5 // indirect | ||
github.com/yuin/gopher-lua v1.1.1 // indirect | ||
go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
go.yaml.in/yaml/v4 v4.0.0-rc.2 // indirect | ||
golang.org/x/crypto v0.42.0 // indirect | ||
golang.org/x/exp v0.0.0-20250911091902-df9299821621 // indirect | ||
golang.org/x/mod v0.28.0 // indirect | ||
golang.org/x/net v0.44.0 // indirect | ||
golang.org/x/sync v0.17.0 // indirect | ||
golang.org/x/sys v0.36.0 // indirect | ||
golang.org/x/term v0.35.0 // indirect | ||
golang.org/x/text v0.29.0 // indirect | ||
golang.org/x/tools v0.37.0 // indirect | ||
google.golang.org/protobuf v1.36.7 // indirect | ||
gopkg.in/inf.v0 v0.9.1 // indirect | ||
gopkg.in/op/go-logging.v1 v1.0.0-20160211212156-b2cb9fa56473 // indirect | ||
gopkg.in/yaml.v2 v2.4.0 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
k8s.io/api v0.34.0 // indirect | ||
k8s.io/apiextensions-apiserver v0.34.0 // indirect | ||
k8s.io/apimachinery v0.34.0 // indirect | ||
k8s.io/code-generator v0.34.0 // indirect | ||
k8s.io/gengo/v2 v2.0.0-20250604051438-85fd79dbfd9f // indirect | ||
k8s.io/klog/v2 v2.130.1 // indirect | ||
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b // indirect | ||
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 // indirect | ||
sigs.k8s.io/controller-tools v0.17.2 // indirect | ||
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect | ||
sigs.k8s.io/randfill v1.0.0 // indirect | ||
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect | ||
sigs.k8s.io/yaml v1.6.0 // indirect | ||
) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have a version set here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the v0.17.2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is just my understing
The selected lines in go.tool.mod list tools without versions because, in a Go toolchain file, the tool block specifies the import paths of command-line tools to be installed, not their versions. The actual versions are managed in the require block below, which ensures the correct versions are used when the tools are installed. This separation keeps the tool list clean and version management centralized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example for vacuum
and version is managed

external-dns/go.mod
Line 113 in c1894f8
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another tool example

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll pin similar question mattermost/mattermost-plugin-starter-template#217 (comment). There are multiple links to read trhough pros/cons if you have spare time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me also it's not a blocker, just weird.