chore(controller-gen): move tools under go tools

[ivankatliarchuk]

What does it do ?

While was testing PR #5814 find out that generated code is missing update.

The change was introduced here #5659

Solution is from here https://www.alexedwards.net/blog/how-to-manage-tool-dependencies-in-go-1.24-plus#using-a-separate-modfile-for-tools

follow-up:

• move vaccum tool under go.tools.mod
• unit-tests for CRDs and generated files, so there is no need to execute validation manually

Motivation

Add unit-tests for CRD generators in follow-up code, similar to https://github.com/kubernetes-sigs/external-dns/tree/master/internal/gen/docs

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[coveralls]

Pull Request Test Coverage Report for Build 18130553619

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 22 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.02%) to 78.577%

---

Files with Coverage Reduction	New Missed Lines	%
endpoint.go	11	90.8%
zz_generated.deepcopy.go	11	0.0%

Totals
Change from base Build 18123647456:	-0.02%
Covered Lines:	15816
Relevant Lines:	20128

---

💛 - Coveralls

[mloiseleur]

Shouldn't we have a version set here ?

[mloiseleur]

Like the v0.17.2 ?

[ivankatliarchuk]

Yeah, this is just my understing

The selected lines in go.tool.mod list tools without versions because, in a Go toolchain file, the tool block specifies the import paths of command-line tools to be installed, not their versions. The actual versions are managed in the require block below, which ensures the correct versions are used when the tools are installed. This separation keeps the tool list clean and version management centralized.

[ivankatliarchuk]

Example for vacuum

tool github.com/daveshanley/vacuum

and version is managed

external-dns/go.mod

Line 113 in c1894f8

github.com/daveshanley/vacuum v0.17.8 // indirect

[ivankatliarchuk]

Another tool example

[ivankatliarchuk]

I'll pin similar question mattermost/mattermost-plugin-starter-template#217 (comment). There are multiple links to read trhough pros/cons if you have spare time.

[mloiseleur]

To me also it's not a blocker, just weird.

[mloiseleur]

/lgtm
@AndrewCharlesHay @vflaux Any comments ?

[ivankatliarchuk]

/approve

[ivankatliarchuk]

/approve cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mloiseleur. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment