fix(controller): panic in OCI provider build

[vflaux]

What does it do ?

Fix a panic when building the OCI provider with missing config fields.

I would have liked to add tests for successful OCI provider builds, but this query the instance metadata API or require a config file, so it's not easy to test as is.

Motivation

fix #5849

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 18260285977

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.06%) to 78.613%

---

Files with Coverage Reduction	New Missed Lines	%
openshift_route.go	1	79.49%

Totals
Change from base Build 18242454154:	0.06%
Covered Lines:	15813
Relevant Lines:	20115

---

💛 - Coveralls

[mloiseleur]

@vflaux The error handling for oci hurt my eyes. Wdyt of my suggestions ?

[mloiseleur]

@jrosinsk @anders-swanson Any comments on this PR ? Do you think you can review it ?

[vflaux]

@vflaux The error handling for oci hurt my eyes. Wdyt of my suggestions ?

I wanted to minimize changes, but yes, it's better.

[mloiseleur]

/lgtm

[jrosinsk]

@jrosinsk @anders-swanson Any comments on this PR ? Do you think you can review it ?

taking a look.

[jrosinsk]

the panic happens on the access to the non-existant ZoneCacheDuration.
another way to fix this would be to just protect that call when there is no config loaded:

`

         if err == nil {
                    config.ZoneCacheDuration = cfg.OCIZoneCacheDuration
                    p, err = oci.NewOCIProvider(*config, domainFilter, zoneIDFilter, cfg.OCIZoneScope, cfg.DryRun)
            }
    case "rfc2136":

`

Seems a bit more confusing with the break statements.