fix(controller): panic in OCI provider build

Author: vflaux

controller/execute.go

@@ -285,8 +285,8 @@ func buildProvider(
 		} else {
 			config, err = oci.LoadOCIConfig(cfg.OCIConfigFile)
 		}
-		config.ZoneCacheDuration = cfg.OCIZoneCacheDuration
 		if err == nil {
+			config.ZoneCacheDuration = cfg.OCIZoneCacheDuration
 			p, err = oci.NewOCIProvider(*config, domainFilter, zoneIDFilter, cfg.OCIZoneScope, cfg.DryRun)
 		}
 	case "rfc2136":

controller/execute_test.go

@@ -264,6 +264,15 @@ func TestBuildProvider(t *testing.T) {
 			},
 			expectedType: "*provider.CachedProvider",
 		},
+		{
+			name: "oci provider instance principal without compartment OCID",
+			cfg: &externaldns.Config{
+				Provider:                 "oci",
+				OCIAuthInstancePrincipal: true,
+				OCICompartmentOCID:       "",
+			},
+			expectedError: "instance principal authentication requested, but no compartment OCID provided",
+		},
 		{
 			name: "coredns provider",
 			cfg: &externaldns.Config{