test(controller): improve code coverage

[TobyTheHutt]

What does it do ?

Improves test coverage on the controller.

• Before (parent e78b385): 65.0% on controller, 79.2% on project
• After (commit a7bb468): 81.9% on controller, 79.8% on project

Motivation

The referenced ticket (#5150), aiming to improve code coverage.
The changes in #5798 should be reviewed separately from the basic checks I also implemented, which is why I propose to merge the "safe" changes first.

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @TobyTheHutt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[ivankatliarchuk]

I'm actually using different metrics make cover-html

Before 46%

With the change 72%

[ivankatliarchuk]

/lgtm

[ivankatliarchuk]

Looks like you have an experience with flags and how to test CLI. There is an issue #5379, which may require multiple PRs, if you want you could try help us migrate

[TobyTheHutt]

I'll give it a look. It seems to me that's quire some work and I don't think I could take responsibility over the whole thing.
If I can wrap my head around it, I'll hit a few PRs though.

[mloiseleur]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment