Skip to content

refactor(source/nat64): optional source & early prefixes parsing #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

refactor(source/nat64): optional source & early prefixes parsing #5810

merged 1 commit into from
Sep 10, 2025

Conversation

@vflaux
Copy link
Contributor

@vflaux vflaux commented Sep 5, 2025 •
edited
Loading

What does it do ?

  • add the nat64 source only when nat64 networks are defined (--nat64-networks)
  • parse nat64 networks when creating the source, not on every Endpoints() call

Motivation

The NAT64 source do nothing when no nat64 networks are defined.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added the controller Issues or PRs related to the controller label Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added source needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2025
ivankatliarchuk
ivankatliarchuk reviewed Sep 5, 2025
View reviewed changes
controller/execute.go
combinedSource = wrappers.NewNAT64Source(combinedSource, cfg.NAT64Networks)
cfg.AddSourceWrapper("nat64")
if len(cfg.NAT64Networks) > 0 {
combinedSource, err = wrappers.NewNAT64Source(combinedSource, cfg.NAT64Networks)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, other wrappers do not return errors. It would be better to define a common interface for all wrappers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean all wrapper's constructors should also return an error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. If one returns an error, I think all should return an error. So we have some level of consistency.

@ivankatliarchuk
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@vflaux
Copy link
Contributor Author

vflaux commented Sep 8, 2025

/retest

@ivankatliarchuk
Copy link
Member

Most likely make sense to do a refactoring in follow-up. ref #5810 (comment)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@mloiseleur
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@vflaux
Copy link
Contributor Author

vflaux commented Sep 10, 2025 •
edited
Loading

I've rebased manually as there was a conflict with a change in #5816.

@ivankatliarchuk
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 55b24ad into kubernetes-sigs:master Sep 10, 2025
13 checks passed
@vflaux vflaux deleted the nat64_source branch September 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vflaux @k8s-ci-robot @ivankatliarchuk @mloiseleur