-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 Improve AfterControlPlaneInitialized documentation #12377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabriziopandini
wants to merge
1
commit into
kubernetes-sigs:main
Choose a base branch
from
fabriziopandini:improve-AfterControlPlaneInitialized-doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -76,8 +76,10 @@ MachineDeployments and the templates derived from the ClusterClass. | |||||
|
||||||
### AfterControlPlaneInitialized | ||||||
|
||||||
This hook is called after the Control Plane for the Cluster is marked as available for the first time. Runtime Extension | ||||||
implementers can use this hook to execute tasks, for example component installation on workload clusters, that are only | ||||||
This hook is called after the Control Plane reports control plane initialized, which means the API server can accept requests. | ||||||
This usually happens sometime during first CP machine provisioning or immediately after. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
Runtime Extension implementers can use this hook to execute tasks, for example component installation on workload clusters, that are only | ||||||
possible once the Control Plane is available. This hook does not block any further changes to the Cluster. | ||||||
|
||||||
#### Example Request: | ||||||
|
@@ -159,7 +161,7 @@ For additional details, you can see the full schema in <button onclick="openSwag | |||||
|
||||||
### AfterControlPlaneUpgrade | ||||||
|
||||||
This hook is called after the control plane has been upgraded to the version specified in `spec.topology.version`, | ||||||
This hook is called after the entire control plane has been upgraded to the version specified in `spec.topology.version`, | ||||||
and immediately before the new version is going to be propagated to the MachineDeployments of the Cluster. | ||||||
Runtime Extension implementers can use this hook to execute post-upgrade add-on tasks and block upgrades to workers | ||||||
until everything is ready. | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.