📖 Improve AfterControlPlaneInitialized documentation #12377
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
mboersma
reviewed
Jun 23, 2025
| @@ -76,8 +76,10 @@ MachineDeployments and the templates derived from the ClusterClass. | |||
|
|
|||
| ### AfterControlPlaneInitialized | |||
|
|
|||
| This hook is called after the Control Plane for the Cluster is marked as available for the first time. Runtime Extension | |||
| implementers can use this hook to execute tasks, for example component installation on workload clusters, that are only | |||
| This hook is called after the Control Plane reports control plane initialized, which means the API server can accept requests. | |||
There was a problem hiding this comment.
Suggested change
| This hook is called after the Control Plane reports control plane initialized, which means the API server can accept requests. | |
| This hook is called after the Control Plane reports that the control plane is initialized, which means the API server can accept requests. |
| This hook is called after the Control Plane for the Cluster is marked as available for the first time. Runtime Extension | ||
| implementers can use this hook to execute tasks, for example component installation on workload clusters, that are only | ||
| This hook is called after the Control Plane reports control plane initialized, which means the API server can accept requests. | ||
| This usually happens sometime during first CP machine provisioning or immediately after. |
There was a problem hiding this comment.
Suggested change
| This usually happens sometime during first CP machine provisioning or immediately after. | |
| This usually happens sometime during the first CP machine provisioning or immediately thereafter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by dropping wording about control plane available, which is not accurate
/area documentation