Skip to content

manifests: align mysql image version between #267 and #703 #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

manifests: align mysql image version between #267 and #703 #1113

merged 1 commit into from
May 19, 2025

Conversation

tarilabs
Copy link
Member

Description

Looks like:

was merged few minutes after the agreed merge of:

this provide the required kustomize alignments

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@tarilabs tarilabs marked this pull request as ready for review May 14, 2025 16:46
@google-oss-prow google-oss-prow bot requested review from rareddy and Tomcli May 14, 2025 16:46
@tarilabs tarilabs mentioned this pull request May 14, 2025
Merged
8 tasks
pboyd
pboyd approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 14, 2025
tarilabs added a commit to tarilabs/model-registry that referenced this pull request May 14, 2025
@tarilabs
Revert "align manifest between kubeflow#267 and kubeflow#703"
d44fda1 
This reverts commit 6c1a4c8.

This is taken care in separate PR:
kubeflow#1113

Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs
Copy link
Member Author

tarilabs commented May 14, 2025 •
edited
Loading

will rebase this after #1112 is merged.

google-oss-prow bot pushed a commit that referenced this pull request May 14, 2025
@tarilabs
gha: refresh AppArmor settings for mysql in gha (#1112)
a098b60 
* gha: remove obsolete apparmor settings for mysql in gha

Signed-off-by: Matteo Mortari <[email protected]>

* align manifest between #267 and #703

Signed-off-by: Matteo Mortari <[email protected]>

* Revert removal (keep AppArmor) and change script

This reverts commit e00cd80.

trying with replacing with apparmor-utils

Signed-off-by: Matteo Mortari <[email protected]>

* pin ubuntu runners to fetch apparmor settings correctly

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "pin ubuntu runners to fetch apparmor settings correctly"

This reverts commit 769d452.

Signed-off-by: Matteo Mortari <[email protected]>

* attempt by forcing apt mirror to lookup for AppArmor

Signed-off-by: Matteo Mortari <[email protected]>

* test by removing directly the profile

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "test by removing directly the profile"

This reverts commit 7eb0455.

Signed-off-by: Matteo Mortari <[email protected]>

* simply remove with apparmor_parser -R

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "align manifest between #267 and #703"

This reverts commit 6c1a4c8.

This is taken care in separate PR:
#1113

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20250514-mysqlkustomize branch from 168f7cf to c3e8eaf Compare May 14, 2025 20:09
@google-oss-prow google-oss-prow bot removed the lgtm label May 14, 2025
@tarilabs tarilabs changed the title manifests: align manifest between #267 and #703 manifests: align mysql image version between #267 and #703 May 14, 2025
@syntaxsdev
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 14, 2025
pboyd
pboyd approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

syntaxsdev pushed a commit to syntaxsdev/model-registry that referenced this pull request May 15, 2025
@tarilabs @syntaxsdev
gha: refresh AppArmor settings for mysql in gha (kubeflow#1112)
7477127 
* gha: remove obsolete apparmor settings for mysql in gha

Signed-off-by: Matteo Mortari <[email protected]>

* align manifest between kubeflow#267 and kubeflow#703

Signed-off-by: Matteo Mortari <[email protected]>

* Revert removal (keep AppArmor) and change script

This reverts commit e00cd80.

trying with replacing with apparmor-utils

Signed-off-by: Matteo Mortari <[email protected]>

* pin ubuntu runners to fetch apparmor settings correctly

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "pin ubuntu runners to fetch apparmor settings correctly"

This reverts commit 769d452.

Signed-off-by: Matteo Mortari <[email protected]>

* attempt by forcing apt mirror to lookup for AppArmor

Signed-off-by: Matteo Mortari <[email protected]>

* test by removing directly the profile

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "test by removing directly the profile"

This reverts commit 7eb0455.

Signed-off-by: Matteo Mortari <[email protected]>

* simply remove with apparmor_parser -R

Signed-off-by: Matteo Mortari <[email protected]>

* Revert "align manifest between kubeflow#267 and kubeflow#703"

This reverts commit 6c1a4c8.

This is taken care in separate PR:
kubeflow#1113

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: Matteo Mortari <[email protected]>
tarilabs
tarilabs commented May 19, 2025
View reviewed changes
Copy link
Member Author

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the 👀

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 01c47c8 into kubeflow:main May 19, 2025
15 checks passed
@Al-Pragliola Al-Pragliola mentioned this pull request May 19, 2025
Merged
5 tasks
tarilabs added a commit to tarilabs/model-registry that referenced this pull request May 20, 2025
@tarilabs
manifests: align default to kubeflow#1113
dcf0c78 
Signed-off-by: Matteo Mortari <[email protected]>
@tarilabs tarilabs mentioned this pull request May 20, 2025
Merged
8 tasks
google-oss-prow bot pushed a commit that referenced this pull request May 20, 2025
@tarilabs
manifests: align default to #1113 (#1137)
4d361d0 
Signed-off-by: Matteo Mortari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboyd pboyd pboyd approved these changes

@rareddy rareddy Awaiting requested review from rareddy

@Tomcli Tomcli Awaiting requested review from Tomcli

Assignees

@pboyd pboyd

@syntaxsdev syntaxsdev

Labels
approved Area/Manifests lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarilabs @syntaxsdev @pboyd