-
Notifications
You must be signed in to change notification settings - Fork 90
gha: refresh AppArmor settings for mysql in gha #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: refresh AppArmor settings for mysql in gha #1112
Conversation
Signed-off-by: Matteo Mortari <[email protected]>
now that's weird, the job failures ( example https://github.com/kubeflow/model-registry/actions/runs/15025633738/job/42225571023?pr=1112 ) reports on Mysql 8.0.x 🤔 |
Looks like: was merged few minutes after the agreed merge of: leading to this inconsistency. on it. |
Signed-off-by: Matteo Mortari <[email protected]>
Unfortunately removing AppArmor exibhit the old issue in
for which we applied AppArmor config in |
This reverts commit e00cd80. trying with replacing with apparmor-utils Signed-off-by: Matteo Mortari <[email protected]>
ce10abb
to
5f84ce8
Compare
Signed-off-by: Matteo Mortari <[email protected]>
This reverts commit 769d452. Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
45316c8
to
7eb0455
Compare
This reverts commit 7eb0455. Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
This reverts commit 6c1a4c8. This is taken care in separate PR: kubeflow#1113 Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* gha: remove obsolete apparmor settings for mysql in gha Signed-off-by: Matteo Mortari <[email protected]> * align manifest between kubeflow#267 and kubeflow#703 Signed-off-by: Matteo Mortari <[email protected]> * Revert removal (keep AppArmor) and change script This reverts commit e00cd80. trying with replacing with apparmor-utils Signed-off-by: Matteo Mortari <[email protected]> * pin ubuntu runners to fetch apparmor settings correctly Signed-off-by: Matteo Mortari <[email protected]> * Revert "pin ubuntu runners to fetch apparmor settings correctly" This reverts commit 769d452. Signed-off-by: Matteo Mortari <[email protected]> * attempt by forcing apt mirror to lookup for AppArmor Signed-off-by: Matteo Mortari <[email protected]> * test by removing directly the profile Signed-off-by: Matteo Mortari <[email protected]> * Revert "test by removing directly the profile" This reverts commit 7eb0455. Signed-off-by: Matteo Mortari <[email protected]> * simply remove with apparmor_parser -R Signed-off-by: Matteo Mortari <[email protected]> * Revert "align manifest between kubeflow#267 and kubeflow#703" This reverts commit 6c1a4c8. This is taken care in separate PR: kubeflow#1113 Signed-off-by: Matteo Mortari <[email protected]> --------- Signed-off-by: Matteo Mortari <[email protected]>
Description
we introduced AppArmor setting as part of:
To move to a later version of MySQL 8.0.x supporting also ARM.
We are currently using MySQL 8.3.0.
Also, application of AppArmor seems to fail for ubuntu-24.04, example:
in
Remove AppArmor profile for mysql in KinD on GHA
step.Seems the AppArmor setting is:
based on historic GHA runs on main.
The proposed changes just skip apt-install of the AppArmor profile, as in later GitHub runner image, they seems to be installed already out-of-the-box, thus avoiding the difference in the mirroring issue above.
How Has This Been Tested?
since the original failure of MySQL happened in GHA, this can only be tested on GHA.
Merge criteria:
DCO
check)ok-to-test
has been added to the PR.If you have UI changes