-
Notifications
You must be signed in to change notification settings - Fork 107
feat(datasets): ibis TableDataset credentials support #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gitgud5000
wants to merge
13
commits into
kedro-org:main
Choose a base branch
from
gitgud5000:ibis-ds-credentials-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(datasets): ibis TableDataset credentials support #1218
gitgud5000
wants to merge
13
commits into
kedro-org:main
from
gitgud5000:ibis-ds-credentials-support
+118
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
6f97810 to
74cbed1
Compare
Signed-off-by: gitgud5000 <[email protected]>
…ypy and surface explicit errors for invalid credential inputs. Signed-off-by: gitgud5000 <[email protected]>
05d047d to
13e8b3b
Compare
Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
|
@deepyaman Opened a new PR with the credentials feature for Didn’t add connection string support yet... not sure if that should go in a separate PR. |
Yeah, separate PR probably better for that. |
Signed-off-by: gitgud5000 <[email protected]>
…de argument (PR kedro-org#1093) and credentials support in the upcoming changes section. Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
Signed-off-by: gitgud5000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #1093
credentialsparameter to accept connection info (dictor string URI).Raises a warning if both.credentialsand deprecatedconnectionare providedAdds backend extraction helper and adjusts._describe()to use itImproves documentation to reflect the preferred usage.Description
credentialsParameter:credentialsas the preferred method for specifying Ibis backend connection configurations.A string connection URI.(with optional.constring)Supersedes the olderconnectionparameter.]Warns if both are provided.Updates both._connect()and_describe()to support new functionalityDevelopment notes
ibis.connect()Credentials Support
credentialsparam to init signature and docstring.constring.Checklist
jsonschema/kedro-catalog-X.XX.jsonif necessaryRELEASE.mdfile