Skip to content

Conversation

@gitgud5000
Copy link
Contributor

@gitgud5000 gitgud5000 commented Oct 19, 2025

From PR #1093

  • feat: Adds a credentials parameter to accept connection info (dict or string URI).
    • Raises a warning if both credentials and deprecated connection are provided.
    • Adds backend extraction helper and adjusts _describe() to use it.
    • Improves documentation to reflect the preferred usage.

Description

  1. credentials Parameter:
    • Introduces credentials as the preferred method for specifying Ibis backend connection configurations.
    • Accepts:
      • A string connection URI.
      • A dictionary of parameters (with optional con string).
    • Supersedes the older connection parameter.
    • ]Warns if both are provided.
    • Updates both _connect() and _describe() to support new functionality.

Development notes

  • ❓Support for passing credentials in different formats supported by ibis.connect()

Credentials Support

  • Added credentials param to init signature and docstring.
  • ❓Accepts either:
    • ❓A connection string (e.g. "duckdb:///my.db")
    • ❓A dict with connection params or a con string.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@gitgud5000 gitgud5000 force-pushed the ibis-ds-credentials-support branch from 6f97810 to 74cbed1 Compare October 19, 2025 07:07
@gitgud5000 gitgud5000 changed the title Ibis ds credentials support feat(datasets): ibis tabledataset credentials support Oct 19, 2025
…ypy and surface explicit errors for invalid credential inputs.

Signed-off-by: gitgud5000 <[email protected]>
@gitgud5000 gitgud5000 force-pushed the ibis-ds-credentials-support branch from 05d047d to 13e8b3b Compare October 19, 2025 07:39
@gitgud5000 gitgud5000 changed the title feat(datasets): ibis tabledataset credentials support feat(datasets): ibis TableDataset credentials support Oct 19, 2025
@gitgud5000 gitgud5000 marked this pull request as ready for review October 19, 2025 07:56
@gitgud5000
Copy link
Contributor Author

@deepyaman Opened a new PR with the credentials feature for TableDataset.

Didn’t add connection string support yet... not sure if that should go in a separate PR.

@deepyaman
Copy link
Member

Didn’t add connection string support yet... not sure if that should go in a separate PR.

Yeah, separate PR probably better for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants