fix(ibis): add credentials type validation to TableDataset. Appease mypy and surface explicit errors for invalid credential inputs.

Author: gitgud5000

kedro-datasets/kedro_datasets/ibis/table_dataset.py

@@ -148,11 +148,15 @@ def __init__(  # noqa: PLR0913
 
         self._table_name = table_name
         self._database = database
-        self._connection_config = connection or (
-            self.DEFAULT_CONNECTION_CONFIG if not credentials else credentials
-        )
+        self._connection_config = connection or self.DEFAULT_CONNECTION_CONFIG
         # Credentials overlay connection config
-        self._connection_config.update(credentials or {})
+        if credentials:
+            if isinstance(credentials, dict):
+                self._connection_config.update(credentials)
+            elif isinstance(credentials, str):
+                raise ValueError("Connection string credentials are not supported for Ibis TableDataset.")
+            else:
+                raise TypeError("Credentials must be a dict or None.")
         self.metadata = metadata
 
         # Set load and save arguments, overwriting defaults if provided.

kedro-datasets/tests/ibis/test_table_dataset.py

@@ -416,6 +416,32 @@ def test_connection_config_with_credentials(
         table_dataset.load()
         assert ("ibis", key) in table_dataset._connections
 
+    @pytest.mark.parametrize(
+        "credentials,expected_exception,expected_message",
+        [
+            (
+                "postgresql://user:pass@localhost/db",
+                ValueError,
+                "Connection string credentials are not supported",
+            ),
+            (123, TypeError, "Credentials must be a dict"),
+            (["backend", "duckdb"], TypeError, "Credentials must be a dict"),
+            (("backend", "duckdb"), TypeError, "Credentials must be a dict"),
+            (True, TypeError, "Credentials must be a dict"),
+        ],
+    )
+    def test_invalid_credentials_types_raise(
+        self, database_name, connection_config, credentials, expected_exception, expected_message
+    ):
+        """Test that invalid credentials types raise appropriate exceptions."""
+        with pytest.raises(expected_exception, match=expected_message):
+            TableDataset(
+                table_name="test",
+                database=database_name,
+                connection=connection_config,
+                credentials=credentials,
+            )
+
     def test_save_data_loaded_using_file_dataset(self, file_dataset, table_dataset):
         """Test interoperability of Ibis datasets sharing a database."""
         dummy_table = file_dataset.load()