Skip to content

Conversation

@whosefriendA
Copy link
Contributor

@whosefriendA whosefriendA commented Sep 24, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Introduced `--resource-eviction-rate` flag to specify the eviction rate during cluster failover.

@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is different from english version.

Shall we update the english first?

@whosefriendA
Copy link
Contributor Author

I will submit the English version later. The corresponding features in the karmada repository have not been merged yet. After the merge, I will change the darft to a normal PR, and then you can review it. Thank you.> Seems this is different from english version.

Shall we update the english first?

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2025
@windsonsea
Copy link
Member

ok, wait for karmada-io/karmada#6777 to get merged.

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2025
@whosefriendA whosefriendA force-pushed the addfailoverdynamicrate branch from 019de1e to 0e3c69c Compare October 31, 2025 03:26
@whosefriendA whosefriendA marked this pull request as ready for review October 31, 2025 03:27
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2025
@karmada-bot karmada-bot requested a review from Poor12 October 31, 2025 03:27
@whosefriendA whosefriendA force-pushed the addfailoverdynamicrate branch from 0e3c69c to 6c785a5 Compare October 31, 2025 04:10
@whosefriendA whosefriendA force-pushed the addfailoverdynamicrate branch from 6c785a5 to 2f73ce6 Compare October 31, 2025 07:17
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
cc @RainbowMango

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls keep the text consistent between en and zh.

@whosefriendA whosefriendA force-pushed the addfailoverdynamicrate branch from 2f73ce6 to 953d2e9 Compare October 31, 2025 07:47
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@XiShanYongYe-Chang
Copy link
Member

/cc @windsonsea

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Seems our preview does not work well. These new text are not included in the preview.

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@whosefriendA whosefriendA changed the title add: failover dynamic rate limit options add failover dynamic rate limit options Oct 31, 2025
Signed-off-by: whosefriendA <[email protected]>

add: en failover dynamic rate limit options

Signed-off-by: whosefriendA <[email protected]>

change to one para

Signed-off-by: whosefriendA <[email protected]>

change to one para

Signed-off-by: whosefriendA <[email protected]>

add example

Signed-off-by: whosefriendA <[email protected]>

change 0 descripution

Signed-off-by: whosefriendA <[email protected]>

add

Signed-off-by: whosefriendA <[email protected]>

keep zn ch same

Signed-off-by: whosefriendA <[email protected]>

add line

Signed-off-by: whosefriendA <[email protected]>
@whosefriendA whosefriendA force-pushed the addfailoverdynamicrate branch from 953d2e9 to fdc23c3 Compare October 31, 2025 09:37
@RainbowMango
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, windsonsea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit e3912cf into karmada-io:main Oct 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants