- 
                Notifications
    You must be signed in to change notification settings 
- Fork 148
add failover dynamic rate limit options #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add failover dynamic rate limit options #898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this is different from english version.
Shall we update the english first?
| I will submit the English version later. The corresponding features in the karmada repository have not been merged yet. After the merge, I will change the darft to a normal PR, and then you can review it. Thank you.> Seems this is different from english version. 
 | 
| ok, wait for karmada-io/karmada#6777 to get merged. | 
        
          
                i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/cluster-failover.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/cluster-failover.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      019de1e    to
    0e3c69c      
    Compare
  
            
          
                i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/cluster-failover.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      0e3c69c    to
    6c785a5      
    Compare
  
            
          
                i18n/zh/docusaurus-plugin-content-docs/current/userguide/failover/cluster-failover.md
              
                Outdated
          
            Show resolved
            Hide resolved
        
      6c785a5    to
    2f73ce6      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @RainbowMango
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls keep the text consistent between en and zh.
2f73ce6    to
    953d2e9      
    Compare
  
    | /cc @windsonsea | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Seems our preview does not work well. These new text are not included in the preview.
Signed-off-by: whosefriendA <[email protected]> add: en failover dynamic rate limit options Signed-off-by: whosefriendA <[email protected]> change to one para Signed-off-by: whosefriendA <[email protected]> change to one para Signed-off-by: whosefriendA <[email protected]> add example Signed-off-by: whosefriendA <[email protected]> change 0 descripution Signed-off-by: whosefriendA <[email protected]> add Signed-off-by: whosefriendA <[email protected]> keep zn ch same Signed-off-by: whosefriendA <[email protected]> add line Signed-off-by: whosefriendA <[email protected]>
953d2e9    to
    fdc23c3      
    Compare
  
    | /lgtm | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, windsonsea The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: