Skip to content

notify-sibling: Trigger during fullsync if only for selected paths #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

notify-sibling: Trigger during fullsync if only for selected paths #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,12 @@ sdbusplus::async::task<void>
Manager::triggerSiblingNotification(
const config::DataSyncConfig& dataSyncCfg, const std::string& srcPath)
{
std::error_code ec;
if (dataSyncCfg._notifySibling.value()._paths.has_value())
{
if (!(dataSyncCfg._notifySibling.value()._paths.value().contains(
srcPath)))
srcPath)) &&
(!fs::equivalent(srcPath, dataSyncCfg._path, ec)))
{
// Modified path doesn't need to notify
lg2::debug("Sibling notification not configured for the path : "
Expand Down Expand Up @@ -394,7 +396,7 @@ sdbusplus::async::task<bool>
{
// Notify only if configured, we know the concrete path,
// and bytes > 0
if (dataSyncCfg._notifySibling && !srcPath.empty() &&
if (dataSyncCfg._notifySibling &&
utility::rsync::getTransferredBytes(result.second) != 0)
{
// Rsync success alone doesn’t guarantee data got updated on the
Expand All @@ -404,7 +406,7 @@ sdbusplus::async::task<bool>
// initiate sibling notification
// NOLINTNEXTLINE
co_await triggerSiblingNotification(dataSyncCfg,
srcPath.string());
currentSrcPath.string());
}
co_return true;
}
Expand Down