notify-sibling: Trigger during fullsync if only for selected paths #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryakpadman
requested review from
RameshIyyar,
manishtwari,
riya461 and
spinler
This change updates the behavior to trigger sibling notifications during
a full sync when the user specifies a list of files to notify within the
configured path.
The change is necessary because, during a full sync, synchronization
occurs on the configured data path rather than on specific files.
Therefore, special handling is required to ensure notifications are
properly triggered in this scenario.
Tested :
Tested in simics that sibling notification is triggering as expected
during both full sync and background sync.
Test Logs:
During Full sync:
```
phosphor-rbmc-data-sync-mgr[4360]: Rsync command: rsync --compress --recursive
--perms --group --owner --times --atimes --update --relative --delete
--delete-missing-args --stats /var/tmp/data-sync/a2p/Host/
/var/lib/phosphor-data-sync/bmc_data_bkp/
phosphor-rbmc-data-sync-mgr[4360]: Rsync cmd return code : 0 : output :
Number of files: 6 (reg: 1, dir: 5)
Number of regular files transferred: 1
Total file size: 16 bytes
Total transferred file size: 16 bytes
phosphor-rbmc-data-sync-mgr[4360]: Notify request
[/var/lib/phosphor-data-sync/notify-sibling/notifyReq_1762948782_ntWpty.json]
created for configured path/var/tmp/data-sync/a2p/Host/
phosphor-rbmc-data-sync-mgr[4360]: Rsync sibling notify cmd : rsync --compress
--recursive --perms --group --owner --times --atimes --update --remove-source-files
/var/lib/phosphor-data-sync/notify-sibling/notifyReq_1762948782_ntWpty.json
/var/lib/phosphor-data-sync/notify-services/
phosphor-rbmc-data-sync-mgr[4360]: Successfully send notify request for the path
[/var/tmp/data-sync/a2p/Host/], under the configured path : [/var/tmp/data-sync/a2p/Host/]
phosphor-rbmc-data-sync-mgr[4360]: Full Sync completed successfully
```
During background(Immediate) Sync:
```
phosphor-rbmc-data-sync-mgr[4380]: Received IN_CLOSE_WRITE for wd : 1 and name : ID
phosphor-rbmc-data-sync-mgr[4380]: Processing an IN_CLOSE_WRITE for /var/tmp/data-sync/a2p/Host/ID
phosphor-rbmc-data-sync-mgr[4380]: Rsync command: rsync --compress --recursive
--perms --group --owner --times --atimes --update --relative --delete
--delete-missing-args --stats /var/tmp/data-sync/a2p/Host/ID
/var/lib/phosphor-data-sync/bmc_data_bkp/
phosphor-rbmc-data-sync-mgr[4380]: Rsync cmd return code : 0 : output :
Number of files: 6 (reg: 1, dir: 5)
Number of created files: 0
Number of deleted files: 0
Number of regular files transferred: 1
Total file size: 20 bytes
phosphor-rbmc-data-sync-mgr[4380]: Notify request
[/var/lib/phosphor-data-sync/notify-sibling/notifyReq_1762948826_iqaax1.json]
created for configured path/var/tmp/data-sync/a2p/Host/
phosphor-rbmc-data-sync-mgr[4380]: Rsync sibling notify cmd : rsync --compress
--recursive --perms --group --owner --times --atimes --update --remove-source-files
/var/lib/phosphor-data-sync/notify-sibling/notifyReq_1762948826_iqaax1.json
/var/lib/phosphor-data-sync/notify-services/
phosphor-rbmc-data-sync-mgr[4380]: Successfully send notify request for the path
[/var/tmp/data-sync/a2p/Host/ID], under the configured path : [/var/tmp/data-sync/a2p/Host/]
```
Change-Id: I4952003c160c9236350451a561a75cc6efc5917b
Signed-off-by: Arya K Padman <[email protected]>
aryakpadman
force-pushed
the
notify-sibling-full-sync
branch
from
15f412f to
f036e09
Compare
spinler
approved these changes
Nov 13, 2025
RameshIyyar
approved these changes
Nov 14, 2025
manishtwari
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the behavior to trigger sibling notifications during a full sync when the user specifies a list of files to notify within the configured path.
The change is necessary because, during a full sync, synchronization occurs on the configured data path rather than on specific files. Therefore, special handling is required to ensure notifications are properly triggered in this scenario.
Change-Id: I4952003c160c9236350451a561a75cc6efc5917b