Add clamping to [-1, 1] for avoid nans in matrix_to_euler conversion #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered strange nan issues when converting from quat_wxyz to euler_ZYX like below:
I found that the issue was from numerical issues making matrix contain values greater than 1 (e.g., 1 + 1e-6). The domain of
torch.acos
andtorch.asin
are [-1, 1], and they return nan if given values outside of this range. Thus, this simply adds clamping to the inputs to these functions to make them robust to these numerical issues.