pyroscope.java: allow custom asprof distributions instead of embeded one. #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Profiler(use Distribution).
aleks-p
approved these changes
Oct 9, 2025
| TmpDir string `alloy:"tmp_dir,attr,optional"` | ||
| ProfilingConfig ProfilingConfig `alloy:"profiling_config,block,optional"` | ||
|
|
||
| // undocumented |
There was a problem hiding this comment.
is the plan to document this at a later time?
There was a problem hiding this comment.
it would be nice if there was a notion of experimental configuration. I am just scared to commiting to maintain this. We can document it / make it public separately.
| format int | ||
| } | ||
|
|
||
| func (a *Archive) SHA1() string { |
There was a problem hiding this comment.
should we make this private?
| dist asprof.Distribution | ||
| err error | ||
| ) | ||
| if a.Dist != "" { |
There was a problem hiding this comment.
Should we add some logging here to know if we are running with an embedded or a custom distribution?
* pyroscope.java: add integration tests fix package name Revert "pyroscope.java: Fix java log level parameter (#4440)" This reverts commit 4909877. move the helper to pyroscope package * second integration test * revert compose tests * revert unneeded changes * fix buildtag * fix buildtag * improve start time for pyroscope container * skip integration test if it's not pyoroscope job * update makefile * pyroscope.java: Fix java log level parameter (#4440) * pyroscope.java: Fix java log level parameter The version bundled of the async profiler has no loglevel parameter: ``` ts=2025-09-16T08:16:50.898924708Z level=error component_path=/profiling.feature component_id=pyroscope.java.java_pods pid=1184752 err="failed to start: asprof failed to run: asprof failed to run /tmp/alloy-asprof-ae0261b1093f2bc4df44a87300fef98dcdebccb5/bin/asprof: exit status 1 Unrecognized option: --loglevel\n" ``` * Quiet is not a valid argument for the async-profiler cli It can only be used for attaching using agent * remove comments * fix --------- Co-authored-by: Christian Simon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtractDistributionsfromasprof.Profilerasprof.Profileralltogether - after decoupling archive extraction logic, turns out it does nothing - useasprof.Distributioninstead everywhere.asprofdistribution - useful for cases when there is a fix for some problem upstream, but alloy has not been updated yet, so users could have a workaround without waiting for pyroscope to update the asprof within the alloy. Also useful for development - clone asprof, run make, point alloy to the build dir.This is for the next release, we should wait before RC is cut