Skip to content

Conversation

korniltsev-grafanista
Copy link
Contributor

@korniltsev-grafanista korniltsev-grafanista commented Sep 17, 2025

#4440 should have been caught by a test

  • add an integration test to the docker-compose test suite edit: could not make it work, will do in a followup
  • add an integration test by spawning containers manually

I could not run the test locally though, containers don't build 🤷 :(

 > [ui-build 4/4] RUN --mount=type=cache,target=/ui/node_modules,sharing=locked     yarn --network-timeout=1200000                                && yarn run build:
0.276 yarn install v1.22.22
0.327 [1/4] Resolving packages...
0.587 [2/4] Fetching packages...
20.66 error Error: getaddrinfo EAI_AGAIN registry.yarnpkg.com
20.66     at GetAddrInfoReqWrap.onlookupall [as oncomplete] (node:dns:120:26)
20.66 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

depends on #4452

@korniltsev-grafanista korniltsev-grafanista requested a review from a team September 17, 2025 10:44
fix package name

Revert "pyroscope.java: Fix java log level parameter (#4440)"

This reverts commit 4909877.

move the helper to pyroscope package
@korniltsev-grafanista korniltsev-grafanista force-pushed the korniltsev/pyroscope-java-integration-tests branch from 61129ea to 1f18dc2 Compare September 17, 2025 11:23
@korniltsev-grafanista korniltsev-grafanista changed the base branch from main to korniltsev/refactor-java-extraction September 17, 2025 12:45
@korniltsev-grafanista korniltsev-grafanista force-pushed the korniltsev/pyroscope-java-integration-tests branch from ffc2da2 to 585c9ef Compare September 17, 2025 12:51
@korniltsev-grafanista korniltsev-grafanista force-pushed the korniltsev/pyroscope-java-integration-tests branch from cd3cd06 to 81e6cd8 Compare September 17, 2025 12:54
* pyroscope.java: Fix java log level parameter

The version bundled of the async profiler has no loglevel parameter:

```
ts=2025-09-16T08:16:50.898924708Z level=error component_path=/profiling.feature component_id=pyroscope.java.java_pods pid=1184752 err="failed to start: asprof failed to run: asprof failed to run /tmp/alloy-asprof-ae0261b1093f2bc4df44a87300fef98dcdebccb5/bin/asprof: exit status 1  Unrecognized option: --loglevel\n"
```

* Quiet is not a valid argument for the async-profiler cli

It can only be used for attaching using agent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants