Skip to content

feat: Support models.get/delete/update in Java #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Support models.get/delete/update in Java #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/genai/tests/models/test_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
model='models/8533706666867163136'
),
exception_if_mldev='404',
skip_in_api_mode='cannot be deleted for multiple times',
),
pytest_helper.TestTableItem(
name='test_delete_model_with_http_options_in_method',
Expand All @@ -44,13 +45,15 @@
),
exception_if_vertex=TEST_API_VERSION,
exception_if_mldev='404',
skip_in_api_mode='cannot be deleted for multiple times',
),
pytest_helper.TestTableItem(
name='test_delete_tuned_model',
parameters=types._DeleteModelParameters(
model='tunedModels/generate-num-9598'
),
exception_if_vertex='404',
skip_in_api_mode='cannot be deleted for multiple times',
),
]
pytestmark = pytest_helper.setup(
Expand Down
8 changes: 3 additions & 5 deletions google/genai/tests/models/test_get.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,21 @@
pytest_helper.TestTableItem(
name='test_get_vertex_tuned_model',
parameters=types._GetModelParameters(
model='models/2121966731898388480'
model='models/2171259487439028224'
),
exception_if_mldev='404',
),
pytest_helper.TestTableItem(
name='test_get_mldev_tuned_model',
parameters=types._GetModelParameters(
model='tunedModels/generate-num-1896'
model='tunedModels/generatenum5443-ekrw7ie9wis23zbeogbw6jq8'
),
exception_if_vertex='404',
),
pytest_helper.TestTableItem(
name='test_get_vertex_tuned_model_with_http_options_in_method',
parameters=types._GetModelParameters(
model='models/2121966731898388480',
model='models/2171259487439028224',
config={
'http_options': test_http_options,
},
Expand All @@ -62,8 +62,6 @@
pytest_helper.TestTableItem(
name='test_get_base_model',
parameters=types._GetModelParameters(model='gemini-1.5-flash'),
# TODO(b/382104121): Add test for base model once Vertex support it.
exception_if_vertex='404',
),
pytest_helper.TestTableItem(
name='test_get_base_model_with_models_prefix',
Expand Down
28 changes: 14 additions & 14 deletions google/genai/tests/models/test_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,20 @@
pytest_helper.TestTableItem(
name='test_mldev_tuned_models_update',
parameters=types._UpdateModelParameters(
model='tunedModels/generate-num-8498',
model='tunedModels/generatenum5443-ekrw7ie9wis23zbeogbw6jq8',
config={
'display_name': 'My tuned gemini-1.0',
'display_name': 'My tuned gemini-1.5',
},
),
exception_if_vertex='404',
),
pytest_helper.TestTableItem(
name='test_vertex_tuned_models_update',
parameters=types._UpdateModelParameters(
model='models/2121966731898388480',
model='models/2171259487439028224',
config={
'description': (
'My SupervisedTuningJob 2024-05-16 13:36:47.332273'
'My SupervisedTuningJob'
),
'default_checkpoint_id': '8',
},
Expand All @@ -48,7 +48,7 @@
pytest_helper.TestTableItem(
name='test_mldev_tuned_models_update_with_http_options_in_method',
parameters=types._UpdateModelParameters(
model='tunedModels/generate-num-8498',
model='tunedModels/generatenum5443-ekrw7ie9wis23zbeogbw6jq8',
config={
'display_name': 'My tuned gemini-1.0',
'http_options': test_http_options,
Expand All @@ -59,10 +59,10 @@
pytest_helper.TestTableItem(
name='test_vertex_tuned_models_update_with_http_options_in_method',
parameters=types._UpdateModelParameters(
model='models/2121966731898388480',
model='models/2171259487439028224',
config={
'description': (
'My SupervisedTuningJob 2024-05-16 13:36:47.332273'
'My SupervisedTuningJob'
),
'default_checkpoint_id': '8',
'http_options': test_http_options,
Expand All @@ -85,7 +85,7 @@ async def test_async_update_tuned_model(client):
if client._api_client.vertexai:
with pytest.raises(errors.ClientError) as e:
await client.aio.models.update(
model='tunedModels/generate-num-8498',
model='tunedModels/generatenum5443-ekrw7ie9wis23zbeogbw6jq8',
config={
'description': 'My tuned gemini-1.0',
'http_options': test_http_options,
Expand All @@ -94,9 +94,9 @@ async def test_async_update_tuned_model(client):
assert '404' in str(e)
else:
response = await client.aio.models.update(
model='tunedModels/generate-num-8498',
model='tunedModels/generatenum5443-ekrw7ie9wis23zbeogbw6jq8',
config={
'description': 'My tuned gemini-1.0',
'description': 'My tuned gemini-1.5',
'http_options': test_http_options,
},
)
Expand All @@ -106,18 +106,18 @@ async def test_async_update_tuned_model(client):
async def test_async_update_model(client):
if client._api_client.vertexai:
response = await client.aio.models.update(
model='models/7687416965014487040',
model='models/2171259487439028224',
config={
'display_name': 'My tuned gemini-1.0',
'display_name': 'My tuned gemini-1.5',
'http_options': test_http_options,
},
)
else:
with pytest.raises(errors.ClientError) as e:
await client.aio.models.update(
model='models/7687416965014487040',
model='models/2171259487439028224',
config={
'display_name': 'My tuned gemini-1.0',
'display_name': 'My tuned gemini-1.5',
'http_options': test_http_options,
},
)
Expand Down