Skip to content

Conversation

adamfweidman
Copy link
Collaborator

Reverts #10627

This isn't working quite yet and shouldn't block releases tonight.

@adamfweidman adamfweidman requested review from a team as code owners October 13, 2025 21:23
Copy link
Contributor

Summary of Changes

Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a revert of a previous change that aimed to integrate the a2a-server package into the automated release and publishing pipelines. The primary motivation for this revert is to unblock current releases, as the initial setup for a2a-server publishing was not fully functional. Consequently, the a2a-server package will not be published or tagged in the current release cycle. Additionally, a correction was made to the main entry point in the a2a-server's package.json to point to dist/index.js.

Highlights

  • Publishing Workflow Reverted: The a2a-server package has been removed from the automated publishing workflow defined in .github/actions/publish-release/action.yml. This includes the removal of its dedicated npm token input, the npm install workspace reference, and the entire publishing step for the package.
  • NPM Tagging Workflow Reverted: The a2a-server package's involvement in the npm tag release workflow, located in .github/actions/tag-npm-release/action.yml, has been undone. This involved removing its npm token input, the step for changing its distribution tag, and updating the dry-run log message to no longer include a2a-server.
  • Package.json Main Entry Point Corrected: The main entry point in packages/a2a-server/package.json was updated from dist/server.js to dist/index.js, correcting the primary entry file for the package.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/release-change-tags.yml
    • .github/workflows/release-manual.yml
    • .github/workflows/release-nightly.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/release-rollback.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the changes from a previous PR that wired up a2a-server for publishing. The changes correctly remove the publishing and tagging steps for @google/gemini-cli-a2a-server from the GitHub Actions workflows. The change to the main entry point in packages/a2a-server/package.json also appears to be a correct fix. The changes are consistent with the goal of reverting the previous functionality.

Copy link

Size Change: -2 B (0%)

Total Size: 17.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.8 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@adamfweidman adamfweidman added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit f342484 Oct 13, 2025
20 checks passed
@adamfweidman adamfweidman deleted the revert-10627-adamfw/a2a-bin-publish branch October 13, 2025 21:32
thacio added a commit to thacio/auditaria that referenced this pull request Oct 14, 2025
adamfweidman added a commit that referenced this pull request Oct 14, 2025
adamfweidman added a commit that referenced this pull request Oct 14, 2025
akhil29 pushed a commit to akhil29/gemini-cli that referenced this pull request Oct 16, 2025
medic-code pushed a commit to medic-code/gemini-cli that referenced this pull request Oct 18, 2025
Millsondylan pushed a commit to Millsondylan/gemini-cli-1 that referenced this pull request Oct 19, 2025
jk-kashe pushed a commit to jk-kashe/gemini-cli that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants