-
Notifications
You must be signed in to change notification settings - Fork 8.9k
chore: resubmit a2a-publishing after rollout #11100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f342484.
Summary of ChangesHello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request re-establishes the publishing mechanism for the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-applies changes to enable publishing the @google/gemini-cli-a2a-server package. The changes primarily affect the release and tagging workflows. My review identified two key issues:
- A critical misconfiguration in
packages/a2a-server/package.jsonwhere themainentry point is set to a likely non-existent path, which would break module resolution. - A high-severity issue in the
publish-releaseworkflow where the dry-run command for the new package is inconsistent with the actual publish command, potentially leading to misleading dry-run results.
I've provided suggestions to correct both of these issues.
|
Size Change: -2 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
9010a1e to
238328e
Compare
238328e to
83413f6
Compare
|
Do you have a test run for this? This was failing last night when I was trying to integrate this into my changes @ #11068 |
Reapply "chore: wire a2a-server up for publishing" (#11064)
This reverts commit f342484.
Also sets tag in
npm publish --workspace="@google/gemini-cli-a2a-server" --tag "staging"workflow.