Skip to content

Conversation

@adamfweidman
Copy link
Collaborator

@adamfweidman adamfweidman commented Oct 14, 2025

Reapply "chore: wire a2a-server up for publishing" (#11064)
This reverts commit f342484.

Also sets tag in npm publish --workspace="@google/gemini-cli-a2a-server" --tag "staging" workflow.

@adamfweidman adamfweidman requested review from a team as code owners October 14, 2025 13:44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-establishes the publishing mechanism for the @google/gemini-cli-a2a-server package, which was previously rolled back. It integrates the a2a-server package into the existing release workflows by adding necessary npm token handling, updating installation commands, and introducing dedicated publishing and tagging steps within the GitHub Actions. Additionally, a minor adjustment was made to the main entry point in the a2a-server's package.json to ensure correct module resolution.

Highlights

  • Re-enabling A2A Server Publishing: This pull request re-applies the functionality to publish the @google/gemini-cli-a2a-server package to npm, which was previously reverted.
  • GitHub Actions Workflow Updates: The publish-release and tag-npm-release GitHub Actions workflows have been updated to include necessary npm tokens, installation steps, and dedicated publishing and tagging logic for the a2a-server package.
  • Package.json Main Entry Point Correction: The main entry in the packages/a2a-server/package.json file has been corrected from dist/index.js to dist/server.js.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/release-change-tags.yml
    • .github/workflows/release-manual.yml
    • .github/workflows/release-nightly.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/release-rollback.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-applies changes to enable publishing the @google/gemini-cli-a2a-server package. The changes primarily affect the release and tagging workflows. My review identified two key issues:

  1. A critical misconfiguration in packages/a2a-server/package.json where the main entry point is set to a likely non-existent path, which would break module resolution.
  2. A high-severity issue in the publish-release workflow where the dry-run command for the new package is inconsistent with the actual publish command, potentially leading to misleading dry-run results.

I've provided suggestions to correct both of these issues.

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

Size Change: -2 B (0%)

Total Size: 17.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.8 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@adamfweidman adamfweidman force-pushed the afw/re-submit-publish branch from 9010a1e to 238328e Compare October 14, 2025 13:48
@adamfweidman adamfweidman force-pushed the afw/re-submit-publish branch from 238328e to 83413f6 Compare October 14, 2025 13:52
@richieforeman
Copy link
Member

Do you have a test run for this? This was failing last night when I was trying to integrate this into my changes @ #11068

@adamfweidman adamfweidman added this pull request to the merge queue Oct 14, 2025
@adamfweidman adamfweidman removed this pull request from the merge queue due to a manual request Oct 14, 2025
@adamfweidman adamfweidman added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 481ba01 Oct 14, 2025
23 of 27 checks passed
@adamfweidman adamfweidman deleted the afw/re-submit-publish branch October 14, 2025 15:19
akhil29 pushed a commit to akhil29/gemini-cli that referenced this pull request Oct 16, 2025
medic-code pushed a commit to medic-code/gemini-cli that referenced this pull request Oct 18, 2025
Millsondylan pushed a commit to Millsondylan/gemini-cli-1 that referenced this pull request Oct 19, 2025
jk-kashe pushed a commit to jk-kashe/gemini-cli that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants