-
Notifications
You must be signed in to change notification settings - Fork 8.7k
chore: wire a2a-server up for publishing #10627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables the publishing of the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Size Change: -2 B (0%) Total Size: 17.8 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request wires up the a2a-server
package for publishing to npm. The changes include updating GitHub Actions for publishing and tagging, refactoring the esbuild
configuration to handle the new package, and modifying the a2a-server
package itself to be publishable. The changes are mostly correct, but I found a critical issue in how the server script checks if it's being run as the main module, which could lead to unintended side effects when the module is imported by other scripts.
1dec9ce
to
1f64083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once the one question is addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit cfb71b9.
Co-authored-by: Jacob Richman <[email protected]>
TL;DR
Dive Deeper
Reviewer Test Plan
Dry run of nightly release: ttps://github.com/google-gemini/gemini-cli/actions/runs/18298575713
(correctly contains dist/a2a-server.mjs).
Testing Matrix
Linked issues / bugs
This PR makes progress on #9207