Skip to content

Conversation

adamfweidman
Copy link
Collaborator

@adamfweidman adamfweidman commented Oct 7, 2025

TL;DR

  • Release scripts now accept a dedicated wombat token and publish @google/gemini-cli-a2a-server alongside the core and CLI artifacts.
  • All release/change-tag workflows plumb the new secret through, and the A2A package ships a bundled executable (dist/a2a-server.mjs) as its bin.

Dive Deeper

  • Publish action adds wombat-token-a2a-server, publishes the server after the CLI, and includes it in the tag/verify steps.
  • Tagging and every workflow that invokes these actions forward WOMBAT_TOKEN_A2A_SERVER; rollback deprecates the server build too.

Reviewer Test Plan

  • npm run build --workspace @google/gemini-cli-a2a-server to build the workspace.
  • npm run bundle to generate the CLI and A2A server bundles.
  • npm pack --workspace @google/gemini-cli-a2a-server and inspect the tarball (for example, tar -tzf … and tar -xOf package/package.json) to confirm dist/index.js and dist/a2a-server.mjs ship with the updated bin.

Dry run of nightly release: ttps://github.com/google-gemini/gemini-cli/actions/runs/18298575713
(correctly contains dist/a2a-server.mjs).

Testing Matrix

🍏 🪟 🐧
npm run x
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

This PR makes progress on #9207

@adamfweidman adamfweidman requested review from a team as code owners October 7, 2025 00:48
Copy link
Contributor

Summary of Changes

Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables the publishing of the @google/gemini-cli-a2a-server package by integrating it into the existing CI/CD release pipeline. It introduces a new npm token for the A2A server, updates various GitHub Actions workflows to handle its publication and tagging, and refines the build process to correctly bundle the server's executable. These changes ensure that the A2A server can be released and distributed alongside other core CLI packages.

Highlights

  • A2A Server Publishing: The @google/gemini-cli-a2a-server package is now integrated into the release process, allowing it to be published to npm.
  • CI/CD Workflow Updates: GitHub Actions workflows for publishing and tagging releases have been updated to include the new A2A server package and its associated npm token.
  • Build Configuration Refinement: The esbuild configuration has been refactored to separately bundle the A2A server, ensuring it produces a distributable a2a-server.mjs file.
  • Package Metadata Enhancement: The packages/a2a-server/package.json now correctly defines its main and bin entry points and is marked as public.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/release-change-tags.yml
    • .github/workflows/release-manual.yml
    • .github/workflows/release-nightly.yml
    • .github/workflows/release-patch-3-release.yml
    • .github/workflows/release-promote.yml
    • .github/workflows/release-rollback.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

github-actions bot commented Oct 7, 2025

Size Change: -2 B (0%)

Total Size: 17.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 17.8 MB -2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 830 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request wires up the a2a-server package for publishing to npm. The changes include updating GitHub Actions for publishing and tagging, refactoring the esbuild configuration to handle the new package, and modifying the a2a-server package itself to be publishable. The changes are mostly correct, but I found a critical issue in how the server script checks if it's being run as the main module, which could lead to unintended side effects when the module is imported by other scripts.

@adamfweidman adamfweidman force-pushed the adamfw/a2a-bin-publish branch from 1dec9ce to 1f64083 Compare October 7, 2025 00:57
Copy link
Collaborator

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the one question is addressed.

Copy link
Collaborator

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Never mind the index.js file exists so no concerns.

@adamfweidman adamfweidman added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit cfb71b9 Oct 13, 2025
20 checks passed
@adamfweidman adamfweidman deleted the adamfw/a2a-bin-publish branch October 13, 2025 12:50
adamfweidman added a commit that referenced this pull request Oct 13, 2025
akhil29 pushed a commit to akhil29/gemini-cli that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants