Skip to content

[3.x] Fix incorrect notifications for MOUSE_ENTER/EXIT #60346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

[3.x] Fix incorrect notifications for MOUSE_ENTER/EXIT #60346

wants to merge 1 commit into from
+12 −12

Conversation

@sriramun
Copy link
Contributor

Solves #60328

over = nullptr (line 2178) incorrectly triggers the condition if (over != gui.mouse_over) (line 2183) otherwise.

@sriramun sriramun requested a review from a team as a code owner April 18, 2022 13:55
@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui cherrypick:3.4 and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 18, 2022
@Calinou Calinou added this to the 3.5 milestone Apr 18, 2022
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 2, 2022
@akien-mga akien-mga added cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release and removed cherrypick:3.4 labels Jul 2, 2022
@akien-mga akien-mga requested a review from RandomShaper July 2, 2022 21:42
@akien-mga
Copy link
Member

akien-mga commented Dec 12, 2022 •
edited
Loading

CC @bruvzg @Sauermann @KoBeWi (note: 3.x)

The master branch doesn't seem to have this bug, but the code has diverged a lot so it's hard to do a side-by-side comparison.

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Dec 12, 2022
@akien-mga akien-mga changed the title Fix incorrect notifications for MOUSE_ENTER/EXIT [3.x] Fix incorrect notifications for MOUSE_ENTER/EXIT Aug 18, 2023
@lawnjelly lawnjelly modified the milestones: 3.6, 3.7 Sep 11, 2024
@illlustr illlustr mentioned this pull request Apr 14, 2025
Merged
@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RandomShaper RandomShaper Awaiting requested review from RandomShaper

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug topic:gui

Projects

3.x release management
Status: PRs for 3.6 beta 1

Milestone

3.7

Development

Successfully merging this pull request may close these issues.

4 participants

@sriramun @akien-mga @Calinou @lawnjelly