Force disable SPIRV debug info on D3D12. #111912
Merged
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Oct 22, 2025
Calinou
added
platform:windows
cherrypick:4.5
Calinou
added
the
cherrypick:4.4
Calinou
requested changes
Oct 22, 2025
There was a problem hiding this comment.
I would modify main/main.cpp to change the message in the --generate-spirv-debug-info help:
Generate SPIR-V debug information (Vulkan only). This allows source-level shader debugging with RenderDoc.
@stuartcarnie Does it work when using Metal?
blueskythlikesclouds
force-pushed
the
disable-spirv-debug-info-on-d3d12
branch
from
2ab782a to
a62b194
Compare
clayjohn
removed
the
cherrypick:4.4
Calinou
approved these changes
Oct 23, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111869.
Question: I figure there's no way for the OS singleton to be nullptr in this function?