Change Go to Line default shortcut to Ctrl+G

[kitbdev]

• Supersedes Change "Goto Line" to use Ctrl + G and support columns as well #57678

Changes default Go to Line shortcut to Ctrl+G (except on macOS)

This is for consistency with other IDEs. VSCode, Rider, Kate, and Sublime Text all use Ctrl+G for Go to Line.

On macOS it is sometimes Cmd+G, but it seems like it is Cmd+L is more common, so I added an override for it to keep the same shortcut as before.
But I can change it here too if we want.

editor/group_selected_nodes also uses Ctrl+G, but it didn't work when the Script Editor was open anyway, and it still works in the 2D/3D editors now.

[Ivorforce]

As a long time macOS user, cmd + l is "go to line", and cmd + g is "go to next search result". So I think you made the right call there.

[Calinou]

Tested locally, it works as expected. Code looks good to me.

On macOS it is sometimes Cmd+G, but it seems like it is Cmd+L is more common

To accomodate for this, you could bind it to both Ctrl + G and Ctrl + L on all platforms with ED_SHORTCUT_ARRAY(). We don't have any conflicts while in the script editor currently.

This is also good for muscle memory if you regularly switch between macOS and other platforms (like yours truly).

[kitbdev]

Updated to use both

[Ivorforce]

I'd rather use cmd + g open for "Go to next match" shortcut. It's one I use all the time in other apps.

I understand trying to match shortcuts across OSs, but personally, I think it's more important to match expected behavior within the OS. But I've met a lot of people who feel different about that 😅 do we have a policy for it?

[kitbdev]

It looks like Find next is set to Meta + G, (and Find Previous is Meta + Shift + G).
I think that Meta is actually the Command key?
So it looks like there is actually a conflict here.

[Ivorforce]

Oh yea, looks like cmd + g actually is already "find next". When I wrote my comment, I searched the shortcuts and didn't find anything, no idea why I didn't just try pressing the buttons 😅

I think that Meta is actually the Command key?

Yes!

[kitbdev]

Changed back to Ctrl+G as default and Cmd+L override on mac.

[Calinou]

Looks good to me, given the above comments.

[Ivorforce]

I'm not sure what our policy is for editor shortcut compatibility, but for me it makes sense to change to something users are more likely to be used to.

[Calinou]

I'm not sure what our policy is for editor shortcut compatibility, but for me it makes sense to change to something users are more likely to be used to.

Historically, we try to follow what other popular code editors do by default (mainly Visual Studio Code, as it often comes first in developer surveys).

[Repiteo]

Thanks!